Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: third_party/zlib/google/zip_unittest.cc

Issue 222243003: Fixed uncompressing files with wrong uncompressed size set. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: white line Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/zlib/google/zip_reader.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/zlib/google/zip_unittest.cc
diff --git a/third_party/zlib/google/zip_unittest.cc b/third_party/zlib/google/zip_unittest.cc
index 22e350f6a841998bc6d4aacf4a32807647b82042..c60643429fead970f4982c12497b64394fd409e4 100644
--- a/third_party/zlib/google/zip_unittest.cc
+++ b/third_party/zlib/google/zip_unittest.cc
@@ -13,6 +13,7 @@
#include "base/files/scoped_temp_dir.h"
#include "base/path_service.h"
#include "base/strings/string_util.h"
+#include "base/strings/stringprintf.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/platform_test.h"
#include "third_party/zlib/google/zip.h"
@@ -302,4 +303,32 @@ TEST_F(ZipTest, ZipFiles) {
}
#endif // defined(OS_POSIX)
+TEST_F(ZipTest, UnzipFilesWithIncorrectSize) {
+ base::FilePath test_data_folder;
+ ASSERT_TRUE(GetTestDataDirectory(&test_data_folder));
+
+ // test_mismatch_size.zip contains files with names from 0.txt to 7.txt with
+ // sizes from 0 to 7 bytes respectively, but the metadata in the zip file says
+ // the uncompressed size is 3 bytes. The ZipReader and minizip code needs to
+ // be clever enough to get all the data out.
+ base::FilePath test_zip_file =
+ test_data_folder.AppendASCII("test_mismatch_size.zip");
+
+ base::ScopedTempDir scoped_temp_dir;
+ ASSERT_TRUE(scoped_temp_dir.CreateUniqueTempDir());
+ const base::FilePath& temp_dir = scoped_temp_dir.path();
+
+ ASSERT_TRUE(zip::Unzip(test_zip_file, temp_dir));
+ EXPECT_TRUE(base::DirectoryExists(temp_dir.AppendASCII("d")));
+
+ for (int i = 0; i < 8; i++) {
+ SCOPED_TRACE(base::StringPrintf("Processing %d.txt", i));
+ base::FilePath file_path = temp_dir.AppendASCII(
+ base::StringPrintf("%d.txt", i));
+ int64 file_size = -1;
+ EXPECT_TRUE(base::GetFileSize(file_path, &file_size));
+ EXPECT_EQ(static_cast<int64>(i), file_size);
+ }
+}
+
} // namespace
« no previous file with comments | « third_party/zlib/google/zip_reader.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698