Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2222403002: Revert of Remove dependency of c/b/loader on c/b/host_zoom_map_impl.h (Closed)

Created:
4 years, 4 months ago by scottmg
Modified:
4 years, 4 months ago
Reviewers:
Tom Sepez, jam
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, wjmaclean, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, Randy Smith (Not in Mondays), yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, loading-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org, mmenke, Ken Rockot(use gerrit already)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove dependency of c/b/loader on c/b/host_zoom_map_impl.h (patchset #9 id:180001 of https://codereview.chromium.org/2211713002/ ) Reason for revert: Looks like there's a race during initialization on chromeos https://bugs.chromium.org/p/chromium/issues/detail?id=635832#c3 Original issue's description: > Remove dependency of c/b/loader on c/b/host_zoom_map_impl.h > > Contrary to previous attempt at: > https://chromium.googlesource.com/chromium/src.git/+/68c6f2ce16d9807b5cb82679099c82c40f39e911 > > RenderFrameMessageFilter is on the IO thread, and is a BrowserAssociatedInterface, so will maintain the ordering of the resource request and the zoom level request. See also https://codereview.chromium.org/2167513003. > > BUG=609607 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/d4423d511f18f4b0d2e94cf17bf6043bee449c55 > Cr-Commit-Position: refs/heads/master@{#410417} TBR=jam@chromium.org,tsepez@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=609607, 635832 Committed: https://crrev.com/3ea157196bfdddd8dc3c82b2e994e4a932b8d46c Cr-Commit-Position: refs/heads/master@{#410705}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -94 lines) Patch
M build/android/pylib/gtest/filter/content_browsertests_disabled View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_message_filter.h View 3 chunks +1 line, -6 lines 0 comments Download
M content/browser/frame_host/render_frame_message_filter.cc View 4 chunks +1 line, -22 lines 0 comments Download
M content/browser/host_zoom_map_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/loader/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/loader/async_resource_handler.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M content/browser/loader/async_resource_handler_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/loader/async_revalidation_manager_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/loader/resource_message_filter.h View 4 chunks +7 lines, -0 lines 0 comments Download
M content/browser/loader/resource_message_filter.cc View 4 chunks +9 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/render_frame_message_filter.mojom View 1 chunk +0 lines, -4 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +7 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.h View 3 chunks +0 lines, -5 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 4 chunks +4 lines, -26 lines 0 comments Download
M content/renderer/render_frame_impl_browsertest.cc View 2 chunks +0 lines, -30 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.h View 4 chunks +6 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
scottmg
Created Revert of Remove dependency of c/b/loader on c/b/host_zoom_map_impl.h
4 years, 4 months ago (2016-08-09 16:43:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222403002/1
4 years, 4 months ago (2016-08-09 16:44:13 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 16:47:24 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 16:49:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ea157196bfdddd8dc3c82b2e994e4a932b8d46c
Cr-Commit-Position: refs/heads/master@{#410705}

Powered by Google App Engine
This is Rietveld 408576698