Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Unified Diff: components/sync/api/entity_change.cc

Issue 2222373003: [Sync] Adding storage key concept for ModelTypeServices. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removing redundant hash value. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sync/api/entity_change.h ('k') | components/sync/api/fake_model_type_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/api/entity_change.cc
diff --git a/components/sync/api/entity_change.cc b/components/sync/api/entity_change.cc
index 7dc04e253998f6c529e13396c76fc1679f01dd2f..e0c1f952108d1c54bd15f56ee0982264dee3e5d9 100644
--- a/components/sync/api/entity_change.cc
+++ b/components/sync/api/entity_change.cc
@@ -7,26 +7,26 @@
namespace syncer_v2 {
// static
-EntityChange EntityChange::CreateAdd(std::string client_tag,
+EntityChange EntityChange::CreateAdd(const std::string& storage_key,
EntityDataPtr data) {
- return EntityChange(client_tag, ACTION_ADD, data);
+ return EntityChange(storage_key, ACTION_ADD, data);
}
// static
-EntityChange EntityChange::CreateUpdate(std::string client_tag,
+EntityChange EntityChange::CreateUpdate(const std::string& storage_key,
EntityDataPtr data) {
- return EntityChange(client_tag, ACTION_UPDATE, data);
+ return EntityChange(storage_key, ACTION_UPDATE, data);
}
// static
-EntityChange EntityChange::CreateDelete(std::string client_tag) {
- return EntityChange(client_tag, ACTION_DELETE, EntityDataPtr());
+EntityChange EntityChange::CreateDelete(const std::string& storage_key) {
+ return EntityChange(storage_key, ACTION_DELETE, EntityDataPtr());
}
-EntityChange::EntityChange(std::string client_tag,
+EntityChange::EntityChange(const std::string& storage_key,
ChangeType type,
EntityDataPtr data)
- : client_tag_(client_tag), type_(type), data_(data) {}
+ : storage_key_(storage_key), type_(type), data_(data) {}
EntityChange::EntityChange(const EntityChange& other) = default;
« no previous file with comments | « components/sync/api/entity_change.h ('k') | components/sync/api/fake_model_type_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698