Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2222373002: Revert of Eliminate kMojoChannelToken usage for render processes (Closed)

Created:
4 years, 4 months ago by huangs
Modified:
4 years, 4 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, jam, nasko+codewatch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Eliminate kMojoChannelToken usage for render processes (patchset #5 id:80001 of https://codereview.chromium.org/2201183005/ ) Reason for revert: Compile error in Webkit Mac Builder. child_thread_impl.cc:272:47: error: non-virtual member function marked 'override' hides virtual member function shell::Connector* connector) override { Original issue's description: > Eliminate kMojoChannelToken usage for render processes > > Changes RenderProcessHostImpl to connect its IPC Channel > by requesting a nominal IPC::mojom::ChannelBootstrap > interface from its shell::Connection to the render process. > > Changes ChildThreadImpl to support binding such requests > by fusing them to its local IPC Channel if the (now deprecated) > kMojoChannelToken was not provided. > > BUG=623396 > R=ben@chromium.org > > Committed: https://crrev.com/7a7f8f7e6977500d09270ff9d9b3817dda5e5b8a > Cr-Commit-Position: refs/heads/master@{#410656} TBR=ben@chromium.org,tsepez@chromium.org,jschuh@chromium.org,rockot@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=623396 Committed: https://crrev.com/703abc1a6e28e5df8b3757f9aa0757cb995098ca Cr-Commit-Position: refs/heads/master@{#410658}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -192 lines) Patch
M content/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/mojo/mojo_shell_context.h View 2 chunks +14 lines, -8 lines 0 comments Download
M content/browser/mojo/mojo_shell_context.cc View 6 chunks +71 lines, -114 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 4 chunks +11 lines, -6 lines 0 comments Download
M content/child/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M content/child/child_thread_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/child_thread_impl.cc View 6 chunks +7 lines, -56 lines 0 comments Download
M ipc/ipc.mojom View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
huangs
Created Revert of Eliminate kMojoChannelToken usage for render processes
4 years, 4 months ago (2016-08-09 14:20:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222373002/1
4 years, 4 months ago (2016-08-09 14:20:45 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 14:21:38 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/703abc1a6e28e5df8b3757f9aa0757cb995098ca Cr-Commit-Position: refs/heads/master@{#410658}
4 years, 4 months ago (2016-08-09 14:23:13 UTC) #7
rapaintworkz3
4 years, 4 months ago (2016-08-10 22:40:49 UTC) #9
Message was sent while issue was closed.
Thank u

Powered by Google App Engine
This is Rietveld 408576698