Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2222363003: [LayoutNG] Add NGText class definition (Closed)

Created:
4 years, 4 months ago by eae
Modified:
4 years, 4 months ago
Reviewers:
cbiesinger
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Add NGText class definition R=cbiesinger@chromium.org BUG=635619 Committed: https://crrev.com/b0bc5dc5abc8ac3ac07fad7ab1eb583701b92600 Cr-Commit-Position: refs/heads/master@{#410742}

Patch Set 1 #

Patch Set 2 : [LayoutNG] Add NGText class definition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/layout/ng/NGText.h View 1 3 chunks +9 lines, -6 lines 0 comments Download
A + third_party/WebKit/Source/core/layout/ng/NGText.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
eae
4 years, 4 months ago (2016-08-09 16:07:30 UTC) #1
cbiesinger
lgtm
4 years, 4 months ago (2016-08-09 16:16:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222363003/20001
4 years, 4 months ago (2016-08-09 16:18:10 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-09 18:13:30 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 18:15:35 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b0bc5dc5abc8ac3ac07fad7ab1eb583701b92600
Cr-Commit-Position: refs/heads/master@{#410742}

Powered by Google App Engine
This is Rietveld 408576698