Implement DocumentTimeline

Implement DocumentTimeline

The Document.timeline property is currently an AnimationTimeline object. The
spec says that it should be a DocumentTimeline, where DocumentTimeline inherits
from AnimationTimeline.

This patch adds the DocumentTimeline IDL file and basic implementation,
excluding the constructor as specified at
http://w3c.github.io/web-animations/#the-documenttimeline-interface.
(The lack of this constructor is the cause of the "Illegal constructor" errors
in the changed LayoutTests expectations.)

This patch also changes the Document.timeline property to be a DocumentTimeline.
This then requires several #includes to be updated, in files that call
document.timeline().someMethod(), even though these 'someMethod's are inherited
from AnimationTimeline.

BUG=624639, 600248
Committed: https://crrev.com/c27a7492ea607447c055a93856c14e614678ac5e
Cr-Commit-Position: refs/heads/master@{#410950}

[suzyh_UTC10 (ex-contributor), 2016-08-09 07:25:15]

suzyh@chromium.org changed reviewers:
+ alancutter@chromium.org

[suzyh_UTC10 (ex-contributor), 2016-08-09 07:27:24]

Could you do an extra-careful review of this one? I'm not confident that I've
done all the AnimationTimeline-->DocumentTimeline conversions that I need to and
that I haven't done any unnecessary ones.

[suzyh_UTC10 (ex-contributor), 2016-08-09 07:27:29]

The CQ bit was checked by suzyh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 07:28:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 08:42:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 08:42:46]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[alancutter (OOO until 2018), 2016-08-10 00:42:09]

lgtm

https://codereview.chromium.org/2222313002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/imported/wpt/web-animations/interfaces/AnimationTimeline/idlharness-expected.txt
(right):

https://codereview.chromium.org/2222313002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/imported/wpt/web-animations/interfaces/AnimationTimeline/idlharness-expected.txt:4:
FAIL DocumentTimeline interface object length assert_equals: wrong value for
DocumentTimeline.length expected 1 but got 0
Not a review: This is a very strange expectation.

https://codereview.chromium.org/2222313002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/animation/DocumentTimeline.h (right):

https://codereview.chromium.org/2222313002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/DocumentTimeline.h:57: } // namespace
blink
I recommend using "git cl upload --no-find-copies" to avoid diffs like this
(also it's faster).

[suzyh_UTC10 (ex-contributor), 2016-08-10 01:15:51]

Updated global-interface-listing-expected.txt


On 2016/08/10 at 00:42:09, alancutter wrote:
> lgtm
> 
>
https://codereview.chromium.org/2222313002/diff/1/third_party/WebKit/LayoutTe...
> File
third_party/WebKit/LayoutTests/imported/wpt/web-animations/interfaces/AnimationTimeline/idlharness-expected.txt
(right):
> 
>
https://codereview.chromium.org/2222313002/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/imported/wpt/web-animations/interfaces/AnimationTimeline/idlharness-expected.txt:4:
FAIL DocumentTimeline interface object length assert_equals: wrong value for
DocumentTimeline.length expected 1 but got 0
> Not a review: This is a very strange expectation.

I've tried looking for a few other IDL files that pass the "interface object
length" test but am none the wiser as to what the difference is. I'll look into
it some more later.


>
https://codereview.chromium.org/2222313002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/animation/DocumentTimeline.h (right):
> 
>
https://codereview.chromium.org/2222313002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/animation/DocumentTimeline.h:57: } // namespace
blink
> I recommend using "git cl upload --no-find-copies" to avoid diffs like this
(also it's faster).

Thanks for the tip - done.

[suzyh_UTC10 (ex-contributor), 2016-08-10 01:16:45]

suzyh@chromium.org changed reviewers:
+ dstockwell@chromium.org

[suzyh_UTC10 (ex-contributor), 2016-08-10 01:17:09]

+dstockwell for core/* OWNERS

[suzyh_UTC10 (ex-contributor), 2016-08-10 01:17:35]

The CQ bit was checked by suzyh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 01:18:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 02:54:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 02:54:58]

Dry run: This issue passed the CQ dry run.

[dstockwell, 2016-08-10 03:51:24]

lgtm

[suzyh_UTC10 (ex-contributor), 2016-08-10 04:08:41]

The CQ bit was checked by suzyh@chromium.org

[suzyh_UTC10 (ex-contributor), 2016-08-10 04:08:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2222313002/#ps20001
(title: "Update global-interface-listing-expected.txt")

[commit-bot: I haz the power, 2016-08-10 04:09:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 04:13:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-10 04:15:04]

Description was changed from

==========
Implement DocumentTimeline

The Document.timeline property is currently an AnimationTimeline object. The
spec says that it should be a DocumentTimeline, where DocumentTimeline inherits
from AnimationTimeline.

This patch adds the DocumentTimeline IDL file and basic implementation,
excluding the constructor as specified at
http://w3c.github.io/web-animations/#the-documenttimeline-interface.
(The lack of this constructor is the cause of the "Illegal constructor" errors
in the changed LayoutTests expectations.)

This patch also changes the Document.timeline property to be a DocumentTimeline.
This then requires several #includes to be updated, in files that call
document.timeline().someMethod(), even though these 'someMethod's are inherited
from AnimationTimeline.

BUG=624639,600248
==========

to

==========
Implement DocumentTimeline

The Document.timeline property is currently an AnimationTimeline object. The
spec says that it should be a DocumentTimeline, where DocumentTimeline inherits
from AnimationTimeline.

This patch adds the DocumentTimeline IDL file and basic implementation,
excluding the constructor as specified at
http://w3c.github.io/web-animations/#the-documenttimeline-interface.
(The lack of this constructor is the cause of the "Illegal constructor" errors
in the changed LayoutTests expectations.)

This patch also changes the Document.timeline property to be a DocumentTimeline.
This then requires several #includes to be updated, in files that call
document.timeline().someMethod(), even though these 'someMethod's are inherited
from AnimationTimeline.

BUG=624639,600248

Committed: https://crrev.com/c27a7492ea607447c055a93856c14e614678ac5e
Cr-Commit-Position: refs/heads/master@{#410950}
==========

[commit-bot: I haz the power, 2016-08-10 04:15:06]

Patchset 2 (id:??) landed as
https://crrev.com/c27a7492ea607447c055a93856c14e614678ac5e
Cr-Commit-Position: refs/heads/master@{#410950}