Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 2222273003: Revert of [KeyedLoadIC] Support Smi "handlers" for element loads (Closed)

Created:
4 years, 4 months ago by Michael Hablich
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@keyed-load-ic-fieldindex
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [KeyedLoadIC] Support Smi "handlers" for element loads (patchset #5 id:80001 of https://codereview.chromium.org/2180273002/ ) Reason for revert: Times out webgl errors: https://bugs.chromium.org/p/chromium/issues/detail?id=635545 Original issue's description: > [KeyedLoadIC] Support Smi "handlers" for element loads > > This is an experiment as far as performance is concerned. If Smi-configured > element loading directly from the dispatcher stub is fast enough, then we > can stop compiling LoadFastElementStubs (and drop the corresponding code). > > Committed: https://crrev.com/c9308147b341596de2733039223918a6202afa5f > Cr-Commit-Position: refs/heads/master@{#38377} BUG=chromium:635545 TBR=ishell@chromium.org,jkummerow@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/d9d719e7a89dfcb90365404574f452009f2cb409 Cr-Commit-Position: refs/heads/master@{#38473}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -323 lines) Patch
M src/code-stub-assembler.h View 2 chunks +3 lines, -13 lines 0 comments Download
M src/code-stub-assembler.cc View 3 chunks +13 lines, -244 lines 0 comments Download
M src/field-index.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/field-index-inl.h View 3 chunks +2 lines, -3 lines 0 comments Download
M src/ic/handler-compiler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/handler-compiler.cc View 3 chunks +5 lines, -14 lines 0 comments Download
D src/ic/handler-configuration.h View 1 chunk +0 lines, -45 lines 0 comments Download
M src/ic/ic.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Michael Hablich
Created Revert of [KeyedLoadIC] Support Smi "handlers" for element loads
4 years, 4 months ago (2016-08-09 06:44:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222273003/1
4 years, 4 months ago (2016-08-09 06:44:20 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 07:17:31 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 07:20:12 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d9d719e7a89dfcb90365404574f452009f2cb409
Cr-Commit-Position: refs/heads/master@{#38473}

Powered by Google App Engine
This is Rietveld 408576698