Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 2222263002: Remove plan add/removeUrl methods from UrlManager (Closed)

Created:
4 years, 4 months ago by cco3
Modified:
4 years, 4 months ago
Reviewers:
gone, mattreynolds
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove plan add/removeUrl methods from UrlManager Now that we track a little more information than a raw String for PhysicalWeb URLs, this change removes the addUrl and removeUrl methods that accept a raw string. BUG=633715 Committed: https://crrev.com/d7ca3b29413be01e9cfe8d939b168c34fd9ee862 Cr-Commit-Position: refs/heads/master@{#410747}

Patch Set 1 #

Messages

Total messages: 11 (4 generated)
cco3
Hi Matt, PTAL
4 years, 4 months ago (2016-08-08 23:59:14 UTC) #2
mattreynolds
lgtm
4 years, 4 months ago (2016-08-09 00:27:37 UTC) #3
cco3
4 years, 4 months ago (2016-08-09 16:31:01 UTC) #5
gone
lgtm
4 years, 4 months ago (2016-08-09 17:01:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222263002/1
4 years, 4 months ago (2016-08-09 17:09:18 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 18:20:38 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 18:25:48 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d7ca3b29413be01e9cfe8d939b168c34fd9ee862
Cr-Commit-Position: refs/heads/master@{#410747}

Powered by Google App Engine
This is Rietveld 408576698