Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2222233002: DevTools: style selected call frames as arrows. (Closed)

Created:
4 years, 4 months ago by pfeldman
Modified:
4 years, 4 months ago
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: style selected call frames as arrows. BUG=635696 Committed: https://crrev.com/ca6678c4129bf36688e434b136ecbcce859ac63d Cr-Commit-Position: refs/heads/master@{#410683}

Patch Set 1 #

Messages

Total messages: 22 (9 generated)
pfeldman
4 years, 4 months ago (2016-08-08 23:25:54 UTC) #2
paulirish
two-two-two-two-two-three-three-zero-zero-two lgtm. There may be some nice followup from chowse after.
4 years, 4 months ago (2016-08-08 23:27:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222233002/1
4 years, 4 months ago (2016-08-08 23:31:32 UTC) #6
lushnikov
Can you please add a screenshot?
4 years, 4 months ago (2016-08-08 23:32:33 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/247406)
4 years, 4 months ago (2016-08-08 23:34:58 UTC) #10
dgozman
On 2016/08/08 23:32:33, lushnikov wrote: > Can you please add a screenshot? +1
4 years, 4 months ago (2016-08-08 23:46:19 UTC) #11
pfeldman
crbug.com was down. added.
4 years, 4 months ago (2016-08-09 01:14:45 UTC) #13
dgozman
This patch seems to affect all the ui lists, not just call stack.
4 years, 4 months ago (2016-08-09 01:17:33 UTC) #14
pfeldman
On 2016/08/09 01:17:33, dgozman wrote: > This patch seems to affect all the ui lists, ...
4 years, 4 months ago (2016-08-09 04:59:56 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222233002/1
4 years, 4 months ago (2016-08-09 14:25:26 UTC) #17
dgozman
lgtm
4 years, 4 months ago (2016-08-09 15:39:55 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 15:47:22 UTC) #20
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 15:51:55 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca6678c4129bf36688e434b136ecbcce859ac63d
Cr-Commit-Position: refs/heads/master@{#410683}

Powered by Google App Engine
This is Rietveld 408576698