Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2222193002: Fix naming nit was_user_requested to user_requested (Closed)

Created:
4 years, 4 months ago by Pete Williamson
Modified:
4 years, 4 months ago
Reviewers:
fgorski
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix naming nit was_user_requested to user_requested BUG=610521 Committed: https://crrev.com/4b9f65cea2a90611d49158efe41016441348aa7a Cr-Commit-Position: refs/heads/master@{#410720}

Patch Set 1 #

Patch Set 2 : fix merge conflict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M components/offline_pages/background/request_coordinator.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/offline_pages/background/save_page_request.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Pete Williamson
As requested. It turns out there were fewer places to rename than I thought, I ...
4 years, 4 months ago (2016-08-08 22:38:30 UTC) #2
fgorski
lgtm
4 years, 4 months ago (2016-08-09 04:27:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222193002/1
4 years, 4 months ago (2016-08-09 16:06:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/233911) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 4 months ago (2016-08-09 16:08:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222193002/20001
4 years, 4 months ago (2016-08-09 16:17:16 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-09 17:18:42 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 17:21:10 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/4b9f65cea2a90611d49158efe41016441348aa7a
Cr-Commit-Position: refs/heads/master@{#410720}

Powered by Google App Engine
This is Rietveld 408576698