Reland use screen space transform to compute translation

Reland use screen space transform to compute translation

The original patch missed out the case where the destination is
non-flat.

Original patch : https://codereview.chromium.org/2187403002/
BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/af1582f1d022ac11e0239b3bcf448269346d5a3b
Cr-Commit-Position: refs/heads/master@{#411097}

[jaydasika, 2016-08-09 23:49:19]

Description was changed from

==========
Reland use screen space transform to compute translation

The original patch missed out the case where the destination is
non-flat.

Original patch : https://codereview.chromium.org/2187403002/
BUG=622372
==========

to

==========
Reland use screen space transform to compute translation

The original patch missed out the case where the destination is
non-flat.

Original patch : https://codereview.chromium.org/2187403002/
BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[jaydasika, 2016-08-10 00:02:51]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org

[jaydasika, 2016-08-10 00:02:52]

PTAL

[jaydasika, 2016-08-10 00:03:06]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 00:04:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 01:08:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 01:08:23]

Dry run: This issue passed the CQ dry run.

[ajuma, 2016-08-10 15:26:45]

lgtm

https://codereview.chromium.org/2222163006/diff/20001/cc/trees/property_tree.cc
File cc/trees/property_tree.cc (right):

https://codereview.chromium.org/2222163006/diff/20001/cc/trees/property_tree....
cc/trees/property_tree.cc:185: // atmost translation, C and B cannot be non-flat
and so flattened(B * A
"at most" (missing space)

https://codereview.chromium.org/2222163006/diff/20001/cc/trees/property_tree....
cc/trees/property_tree.cc:187: // multiple D's ToScreen transform with
flattened(A * R)^{-1}, which is
"multiply"

[jaydasika, 2016-08-10 17:12:38]

https://codereview.chromium.org/2222163006/diff/20001/cc/trees/property_tree.cc
File cc/trees/property_tree.cc (right):

https://codereview.chromium.org/2222163006/diff/20001/cc/trees/property_tree....
cc/trees/property_tree.cc:185: // atmost translation, C and B cannot be non-flat
and so flattened(B * A
On 2016/08/10 15:26:45, ajuma wrote:
> "at most" (missing space)

Done.

https://codereview.chromium.org/2222163006/diff/20001/cc/trees/property_tree....
cc/trees/property_tree.cc:187: // multiple D's ToScreen transform with
flattened(A * R)^{-1}, which is
On 2016/08/10 15:26:45, ajuma wrote:
> "multiply"

Done.

[jaydasika, 2016-08-10 17:12:41]

The CQ bit was checked by jaydasika@chromium.org

[jaydasika, 2016-08-10 17:12:42]

The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/2222163006/#ps40001
(title: ".")

[commit-bot: I haz the power, 2016-08-10 17:13:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 18:39:57]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-10 18:43:20]

Description was changed from

==========
Reland use screen space transform to compute translation

The original patch missed out the case where the destination is
non-flat.

Original patch : https://codereview.chromium.org/2187403002/
BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Reland use screen space transform to compute translation

The original patch missed out the case where the destination is
non-flat.

Original patch : https://codereview.chromium.org/2187403002/
BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/af1582f1d022ac11e0239b3bcf448269346d5a3b
Cr-Commit-Position: refs/heads/master@{#411097}
==========

[commit-bot: I haz the power, 2016-08-10 18:43:21]

Patchset 3 (id:??) landed as
https://crrev.com/af1582f1d022ac11e0239b3bcf448269346d5a3b
Cr-Commit-Position: refs/heads/master@{#411097}