third_party/WebKit/LayoutTests/media/media-controls.js - Issue 2222163005: Updating media controls to give fullscreen button highest priority

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/media-controls.js

Issue 2222163005: Updating media controls to give fullscreen button highest priority (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comment Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/fullscreen-controls-visible-last.html ('k') | third_party/WebKit/LayoutTests/media/video-controls-fullscreen.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/media-controls.js

diff --git a/third_party/WebKit/LayoutTests/media/media-controls.js b/third_party/WebKit/LayoutTests/media/media-controls.js

index c88eb7544a9971dcbbd4412ad123079d937adca1..572d4d468081804fc450e91f3cce505a8f6c6cdb 100644

--- a/third_party/WebKit/LayoutTests/media/media-controls.js

+++ b/third_party/WebKit/LayoutTests/media/media-controls.js

@@ -225,3 +225,9 @@ function runAfterHideMediaControlsTimerFired(func, mediaElement)

setTimeout(func, hideTimeoutMs);

}

+function hasFullscreenButton(element)

+ var size = mediaControlsButtonDimensions(element, "fullscreen-button");

+ return size[0] > 0 && size[1] > 0;