Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2222153002:
Fix synthetic bolding of system fonts on Linux/Android (Closed)
|
Created:
4 years, 4 months ago by Tom (Use chromium acct) Modified:
4 years, 4 months ago CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix synthetic bolding of system fonts on Linux/Android
Fixes a bug introduced by https://codereview.chromium.org/1912013002
Stolen from drott@'s CL https://codereview.chromium.org/2225723003
TBR=eae@
BUG=619464
Committed: https://crrev.com/6da9f6f5e38dfd98ac40055c441aa3c9fe768877
Cr-Commit-Position: refs/heads/master@{#410498}
Patch Set 1 #
Messages
Total messages: 23 (13 generated)
Description was changed from ========== Fix synthetic bolding of system fonts on Linux/Android BUG=619464 ========== to ========== Fix synthetic bolding of system fonts on Linux/Android Fixes a bug introduced by https://codereview.chromium.org/1912013002 Stolen from drott@'s CL https://codereview.chromium.org/2225723003 BUG=619464 ==========
thomasanderson@google.com changed reviewers: + bungeman@chromium.org, bungeman@google.com, drott@chromium.org, eae@chromium.org
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
eae@ for review and OWNERS bungeman@, please review
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Fix synthetic bolding of system fonts on Linux/Android Fixes a bug introduced by https://codereview.chromium.org/1912013002 Stolen from drott@'s CL https://codereview.chromium.org/2225723003 BUG=619464 ========== to ========== Fix synthetic bolding of system fonts on Linux/Android Fixes a bug introduced by https://codereview.chromium.org/1912013002 Stolen from drott@'s CL https://codereview.chromium.org/2225723003 TBR=eae@ BUG=619464 ==========
The CQ bit was checked by thomasanderson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
dpranke@chromium.org changed reviewers: + dpranke@chromium.org
lgtm.
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix synthetic bolding of system fonts on Linux/Android Fixes a bug introduced by https://codereview.chromium.org/1912013002 Stolen from drott@'s CL https://codereview.chromium.org/2225723003 TBR=eae@ BUG=619464 ========== to ========== Fix synthetic bolding of system fonts on Linux/Android Fixes a bug introduced by https://codereview.chromium.org/1912013002 Stolen from drott@'s CL https://codereview.chromium.org/2225723003 TBR=eae@ BUG=619464 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix synthetic bolding of system fonts on Linux/Android Fixes a bug introduced by https://codereview.chromium.org/1912013002 Stolen from drott@'s CL https://codereview.chromium.org/2225723003 TBR=eae@ BUG=619464 ========== to ========== Fix synthetic bolding of system fonts on Linux/Android Fixes a bug introduced by https://codereview.chromium.org/1912013002 Stolen from drott@'s CL https://codereview.chromium.org/2225723003 TBR=eae@ BUG=619464 Committed: https://crrev.com/6da9f6f5e38dfd98ac40055c441aa3c9fe768877 Cr-Commit-Position: refs/heads/master@{#410498} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/6da9f6f5e38dfd98ac40055c441aa3c9fe768877 Cr-Commit-Position: refs/heads/master@{#410498}
Message was sent while issue was closed.
Thanks for landing the fix, Thomas. On Linux, the set of system fonts for layout test is hardcoded, would it be possible to create a layout test for Linux at least, which exercises this? I think this would consist of finding a character that's only available in a non-bold font and formatting it as bold?
Message was sent while issue was closed.
On 2016/08/09 05:11:21, drott wrote: > Thanks for landing the fix, Thomas. On Linux, the set of system fonts for layout > test is hardcoded, would it be possible to create a layout test for Linux at > least, which exercises this? I think this would consist of finding a character > that's only available in a non-bold font and formatting it as bold? Np, thanks for writing the fix :) see https://bugs.chromium.org/p/chromium/issues/detail?id=619464#c25
Message was sent while issue was closed.
LGTM |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
