Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2222133002:
[layoutng] Initial version of block layout (Closed)
|
Created:
4 years, 4 months ago by cbiesinger Modified:
4 years, 4 months ago CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[layoutng] Initial version of block layout
Also contains a way to create a constraint space from a LayoutBox
R=ikilpatrick@chromium.org
BUG=635619
Committed: https://crrev.com/d92c803780e603b1e99e79cdc3af847677c8c5c7
Cr-Commit-Position: refs/heads/master@{#410552}
Patch Set 1 #Patch Set 2 : better way to get the height #Patch Set 3 : rebased #
Messages
Total messages: 35 (17 generated)
cbiesinger@chromium.org changed reviewers: + glebl@chromium.org
lgtm
The CQ bit was checked by cbiesinger@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ikilpatrick@chromium.org Link to the patchset: https://codereview.chromium.org/2222133002/#ps20001 (title: "better way to get the height")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by cbiesinger@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by cbiesinger@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
The CQ bit was checked by cbiesinger@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for third_party/WebKit/Source/core/core.gypi:
While running git apply --index -3 -p1;
error: patch failed: third_party/WebKit/Source/core/core.gypi:541
Falling back to three-way merge...
Applied patch to 'third_party/WebKit/Source/core/core.gypi' with conflicts.
U third_party/WebKit/Source/core/core.gypi
Patch: third_party/WebKit/Source/core/core.gypi
Index: third_party/WebKit/Source/core/core.gypi
diff --git a/third_party/WebKit/Source/core/core.gypi
b/third_party/WebKit/Source/core/core.gypi
index
337e42c324d25ad81d5d55ef59b7efa902783d4c..72dcda471a177349773c8a0b2344a23744326079
100644
--- a/third_party/WebKit/Source/core/core.gypi
+++ b/third_party/WebKit/Source/core/core.gypi
@@ -541,6 +541,8 @@
'layout/api/LineLayoutText.h',
'layout/api/LineLayoutTextCombine.h',
'layout/api/SelectionState.h',
+ 'layout/ng/NGBlockLayoutAlgorithm.cpp',
+ 'layout/ng/NGBlockLayoutAlgorithm.h',
'layout/ng/NGConstraintSpace.cpp',
'layout/ng/NGConstraintSpace.h',
'layout/BidiRun.h',
The CQ bit was checked by cbiesinger@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ikilpatrick@chromium.org Link to the patchset: https://codereview.chromium.org/2222133002/#ps40001 (title: "rebased")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
The CQ bit was checked by cbiesinger@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
The CQ bit was checked by cbiesinger@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [layoutng] Initial version of block layout Also contains a way to create a constraint space from a LayoutBox R=ikilpatrick@chromium.org BUG=635619 ========== to ========== [layoutng] Initial version of block layout Also contains a way to create a constraint space from a LayoutBox R=ikilpatrick@chromium.org BUG=635619 Committed: https://crrev.com/d92c803780e603b1e99e79cdc3af847677c8c5c7 Cr-Commit-Position: refs/heads/master@{#410552} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/d92c803780e603b1e99e79cdc3af847677c8c5c7 Cr-Commit-Position: refs/heads/master@{#410552} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
