Issue 222213004: Merged r19804, r19890, r19894, r19935 into 3.24 branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 222213004: Merged r19804, r19890, r19894, r19935 into 3.24 branch. (Closed)

Created:
6 years, 8 months ago by Jakob Kummerow

Modified:
6 years, 8 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/3.24

Visibility:
Public.

More Reviews

Description

Merged r19804, r19890, r19894, r19935 into 3.24 branch. fix bad access check check Check that constant is an integer before getting its value in HGraphBuilder::MatchRotateRight. Simplify GetEnumPropertyKeys and avoid trimming fixed arrays in large object space. Fix generalization with callbacks. BUG=351263, 352070, 352588 LOG=N R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20441

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -90 lines)			Patch
M	src/handles.cc	View	1 chunk	+3 lines, -26 lines	0 comments	Download
M	src/hydrogen.cc	View	1 chunk	+1 line, -7 lines	0 comments	Download
M	src/objects.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.cc	View	4 chunks	+23 lines, -28 lines	0 comments	Download
M	src/version.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	test/mjsunit/regress/regress-351263.js	View	1 chunk	+7 lines, -11 lines	0 comments	Download
A +	test/mjsunit/regress/regress-crbug-351262.js	View	1 chunk	+2 lines, -8 lines	0 comments	Download
A +	test/mjsunit/regress/regress-migrate-callbacks.js	View	1 chunk	+7 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r20441.

Expand Messages | Collapse Messages