Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 222213002: Ensure correct alignment of the pushAllArgumentsARM stub. (Closed)

Created:
6 years, 8 months ago by Vyacheslav Egorov (Chromium)
Modified:
6 years, 8 months ago
CC:
blink-reviews, haraken, kouhei+heap_chromium.org, Mads Ager (chromium)
Visibility:
Public.

Description

Ensure correct alignment of the pushAllArgumentsARM stub. BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170656

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M Source/heap/asm/SaveRegisters_arm.S View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Vyacheslav Egorov (Chromium)
PTAL
6 years, 8 months ago (2014-04-02 14:02:44 UTC) #1
Mads Ager (chromium)
LGTM (painful)
6 years, 8 months ago (2014-04-02 14:03:43 UTC) #2
Vyacheslav Egorov (Chromium)
The CQ bit was checked by vegorov@chromium.org
6 years, 8 months ago (2014-04-02 14:16:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vegorov@chromium.org/222213002/1
6 years, 8 months ago (2014-04-02 14:17:09 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 14:17:50 UTC) #5
Message was sent while issue was closed. 
Change committed as 170656

Powered by Google App Engine
This is Rietveld 408576698