Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Unified Diff: net/http/bidirectional_stream.h

Issue 2222113003: Add UMA to net::BidirectionalStream (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/bidirectional_stream.cc » ('j') | net/http/bidirectional_stream.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/bidirectional_stream.h
diff --git a/net/http/bidirectional_stream.h b/net/http/bidirectional_stream.h
index 635cf5b795174f8c67baa5b643da2742a65f7b15..98db75b6e8d19b7ddd5d544c47ac0512d527f9ac 100644
--- a/net/http/bidirectional_stream.h
+++ b/net/http/bidirectional_stream.h
@@ -19,6 +19,10 @@
class GURL;
+namespace base {
+class TickClock;
+} // namespace base
mef 2016/08/10 01:05:20 Add class TimeTicks?
xunjieli 2016/08/11 12:50:40 Done. I included the header file instead since tha
+
namespace net {
class HttpAuthController;
@@ -218,6 +222,8 @@ class NET_EXPORT BidirectionalStream
// Helper method to notify delegate if there is an error.
void NotifyFailed(int error);
+ void UpdateHistograms();
+
// BidirectionalStreamRequestInfo used when requesting the stream.
std::unique_ptr<BidirectionalStreamRequestInfo> request_info_;
const BoundNetLog net_log_;
@@ -248,6 +254,14 @@ class NET_EXPORT BidirectionalStream
// List of buffer length.
std::vector<int> write_buffer_len_list_;
+ base::TimeTicks start_time_;
+ base::TimeTicks read_start_time_;
+ base::TimeTicks read_end_time_;
+ base::TimeTicks send_start_time_;
+ base::TimeTicks send_end_time_;
+
+ std::unique_ptr<base::TickClock> tick_clock_;
+
base::WeakPtrFactory<BidirectionalStream> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(BidirectionalStream);
« no previous file with comments | « no previous file | net/http/bidirectional_stream.cc » ('j') | net/http/bidirectional_stream.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698