Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(974)

Issue 2222093003: ash: Move ShelfWindowTargeter construction from ShelfWidget to RootWindowController (Closed)

Created:
4 years, 4 months ago by James Cook
Modified:
4 years, 4 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ash: Move ShelfWindowTargeter construction from ShelfWidget to RootWindowController This eliminates aura::Window dependencies from ShelfWidget, which we need to do to get it running in mus/mash. mus will need a different implementation of this feature. BUG=615155, 636010 TEST=existing ash_unittests for ShelfWidget Committed: https://crrev.com/752e8df8664956328150560c93c13e3c00a6987f Cr-Commit-Position: refs/heads/master@{#410781}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M ash/root_window_controller.cc View 2 chunks +14 lines, -5 lines 0 comments Download
M ash/shelf/shelf_widget.cc View 3 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
James Cook
msw, please take a look.
4 years, 4 months ago (2016-08-09 18:17:18 UTC) #4
msw
lgtm
4 years, 4 months ago (2016-08-09 18:55:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222093003/1
4 years, 4 months ago (2016-08-09 19:28:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 19:54:55 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 19:57:35 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/752e8df8664956328150560c93c13e3c00a6987f
Cr-Commit-Position: refs/heads/master@{#410781}

Powered by Google App Engine
This is Rietveld 408576698