Use the frame time from Choreographer for computeScroll animation time.

Use the frame time from Choreographer for computeScroll animation time.

This is to reduce jank in fling animations.
See internal bug b/30674719 for more details.

BUG=635607

[hush (inactive), 2016-08-08 18:37:06]

Description was changed from

==========
Use the frame time from Choreographer for computeScroll animation time.

This is to reduce jank in fling animations.
See internal bug b/30674719 for more details.

BUG=
==========

to

==========
Use the frame time from Choreographer for computeScroll animation time.

This is to reduce jank in fling animations.
See internal bug b/30674719 for more details.

BUG=635607
==========

[hush (inactive), 2016-08-08 18:37:24]

hush@chromium.org changed reviewers:
+ boliu@chromium.org

[hush (inactive), 2016-08-08 18:37:24]

PTAL

[boliu, 2016-08-08 18:40:52]

lgtm

in case anyone wonders why webview can't use the time from begin frame like
chrome, it's because this wonderful api can (in theory) be called outside of
frames

[hush (inactive), 2016-08-08 20:07:34]

hush@chromium.org changed reviewers:
+ twellington@chromium.org

[hush (inactive), 2016-08-08 20:07:35]

Hello Theresa
PTAL

[Theresa, 2016-08-10 00:36:17]

lgtm

[hush (inactive), 2016-08-10 22:45:16]

Sorry people! I must have been dreaming while I was working on the first patch
set. It obviously didn't compile.

I just updated the CL and verified it worked.

[hush (inactive), 2016-08-10 22:45:21]

The CQ bit was checked by hush@chromium.org to run a CQ dry run

[boliu, 2016-08-10 22:46:08]

The CQ bit was unchecked by boliu@chromium.org

[commit-bot: I haz the power, 2016-08-10 22:46:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[boliu, 2016-08-10 22:48:24]

Well that in theory needs to be removed again, but I realized this case doesn't
actually work:

> in case anyone wonders why webview can't use the time from begin frame like
> chrome, it's because this wonderful api can (in theory) be called outside of
> frames

If compute scroll is called outside of frames, it won't actually advance the
animation with this implementation.

1) that's probably not ok
2) even if it is ok, this implementation is wrong, because it should just use
the latest timestamp from the last begin frame

[Theresa, 2016-08-12 18:38:47]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 18:39:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 19:48:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 19:48:46]

Dry run: This issue passed the CQ dry run.

[hush (inactive), 2016-08-23 23:14:57]

On 2016/08/10 22:48:24, boliu wrote:
> Well that in theory needs to be removed again, but I realized this case
doesn't
> actually work:
> 
> > in case anyone wonders why webview can't use the time from begin frame like
> > chrome, it's because this wonderful api can (in theory) be called outside of
> > frames
> 
> If compute scroll is called outside of frames, it won't actually advance the
> animation with this implementation.
> 
> 1) that's probably not ok
> 2) even if it is ok, this implementation is wrong, because it should just use
> the latest timestamp from the last begin frame

okay, we just talked in person and figured that there wasn't any reasonable way
to do this, without breaking the case of app calling computeScroll() outside of
frames and then software onDraws to tick animations. I'm going to close this
bug.