Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Unified Diff: content/browser/shared_worker/shared_worker_service_impl.cc

Issue 2222063002: Check that all shared workers are terminated. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/shared_worker/shared_worker_service_impl.cc
diff --git a/content/browser/shared_worker/shared_worker_service_impl.cc b/content/browser/shared_worker/shared_worker_service_impl.cc
index 64bbe0b21943984a66b9e9c87ad08d7eeda38f49..cdb4ca4901fcce725d0d6582ffb24c4de9fe5c8c 100644
--- a/content/browser/shared_worker/shared_worker_service_impl.cc
+++ b/content/browser/shared_worker/shared_worker_service_impl.cc
@@ -446,6 +446,15 @@ void SharedWorkerServiceImpl::NotifyWorkerDestroyed(int worker_process_id,
WorkerDestroyed(worker_process_id, worker_route_id));
}
+// TODO(alokp): Remove after collecting crash data.
+// Temporary checks to verify that all shared workers are terminated.
+// It is suspected that shared workers prevent render process hosts
+// from shutting down: crbug.com/608049
+void SharedWorkerServiceImpl::CheckAllWorkersTerminated() {
+ std::set<int> dependent_renderers = GetRenderersWithWorkerDependency();
+ CHECK_EQ(0u, dependent_renderers.size());
+}
+
blink::WebWorkerCreationError
SharedWorkerServiceImpl::ReserveRenderProcessToCreateWorker(
std::unique_ptr<SharedWorkerPendingInstance> pending_instance) {

Powered by Google App Engine
This is Rietveld 408576698