Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: content/browser/browser_process_sub_thread.cc

Issue 2222063002: Check that all shared workers are terminated. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_process_sub_thread.cc
diff --git a/content/browser/browser_process_sub_thread.cc b/content/browser/browser_process_sub_thread.cc
index 5aadda5ad1edc4c61595f24326eeee25b90209f2..72ffbe36e7c92c2ccb5373abe9490743fd36f0fc 100644
--- a/content/browser/browser_process_sub_thread.cc
+++ b/content/browser/browser_process_sub_thread.cc
@@ -11,6 +11,7 @@
#include "content/browser/browser_child_process_host_impl.h"
#include "content/browser/gpu/browser_gpu_memory_buffer_manager.h"
#include "content/browser/notification_service_impl.h"
+#include "content/browser/shared_worker/shared_worker_service_impl.h"
#include "net/url_request/url_fetcher.h"
#include "net/url_request/url_request.h"
@@ -60,6 +61,12 @@ void BrowserProcessSubThread::CleanUp() {
}
void BrowserProcessSubThread::IOThreadPreCleanUp() {
+ // TODO(alokp): Remove after collecting crash data.
+ // Temporary checks to verify that all shared workers are terminated.
+ // It is suspected that shared workers prevent render process hosts
+ // from shutting down: crbug.com/608049
+ SharedWorkerServiceImpl::GetInstance()->CheckAllWorkersTerminated();
+
// Kill all things that might be holding onto
// net::URLRequest/net::URLRequestContexts.

Powered by Google App Engine
This is Rietveld 408576698