Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Side by Side Diff: content/browser/browser_main_loop.cc

Issue 2222063002: Check that all shared workers are terminated. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/browser_main_loop.h" 5 #include "content/browser/browser_main_loop.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <string> 9 #include <string>
10 #include <utility> 10 #include <utility>
(...skipping 1086 matching lines...) Expand 10 before | Expand all | Expand 10 after
1097 break; 1097 break;
1098 } 1098 }
1099 case BrowserThread::CACHE: { 1099 case BrowserThread::CACHE: {
1100 TRACE_EVENT0("shutdown", "BrowserMainLoop::Subsystem:CacheThread"); 1100 TRACE_EVENT0("shutdown", "BrowserMainLoop::Subsystem:CacheThread");
1101 ResetThread_CACHE(std::move(cache_thread_)); 1101 ResetThread_CACHE(std::move(cache_thread_));
1102 break; 1102 break;
1103 } 1103 }
1104 case BrowserThread::IO: { 1104 case BrowserThread::IO: {
1105 TRACE_EVENT0("shutdown", "BrowserMainLoop::Subsystem:IOThread"); 1105 TRACE_EVENT0("shutdown", "BrowserMainLoop::Subsystem:IOThread");
1106 ResetThread_IO(std::move(io_thread_)); 1106 ResetThread_IO(std::move(io_thread_));
1107
1108 // TODO(alokp): Remove after collecting crash data.
1109 // Temporary checks to verify that all shared workers are terminated.
horo 2016/08/09 04:03:24 Nit: s/shared workers/shared workers and service w
1110 // It is suspected that shared workers prevent render process hosts
1111 // from shutting down: crbug.com/608049
1112 RenderProcessHostImpl::CheckAllWorkersTerminated();
1107 break; 1113 break;
1108 } 1114 }
1109 case BrowserThread::UI: 1115 case BrowserThread::UI:
1110 case BrowserThread::ID_COUNT: 1116 case BrowserThread::ID_COUNT:
1111 default: 1117 default:
1112 NOTREACHED(); 1118 NOTREACHED();
1113 break; 1119 break;
1114 } 1120 }
1115 } 1121 }
1116 { 1122 {
(...skipping 397 matching lines...) Expand 10 before | Expand all | Expand 10 after
1514 scoped_refptr<base::SingleThreadTaskRunner> worker_task_runner = 1520 scoped_refptr<base::SingleThreadTaskRunner> worker_task_runner =
1515 audio_thread_->task_runner(); 1521 audio_thread_->task_runner();
1516 audio_manager_ = media::AudioManager::Create(std::move(audio_task_runner), 1522 audio_manager_ = media::AudioManager::Create(std::move(audio_task_runner),
1517 std::move(worker_task_runner), 1523 std::move(worker_task_runner),
1518 MediaInternals::GetInstance()); 1524 MediaInternals::GetInstance());
1519 } 1525 }
1520 CHECK(audio_manager_); 1526 CHECK(audio_manager_);
1521 } 1527 }
1522 1528
1523 } // namespace content 1529 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | content/browser/browser_process_sub_thread.cc » ('j') | content/browser/renderer_host/render_process_host_impl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698