Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2222053002: [turbofan] Improve typing rules for various builtins. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Improve typing rules for various builtins. Sanitize the typing rules for the various supported Math builtins, and add appropriate typing rules for various Number, String, Object and global builtins as well. R=franzih@chromium.org Committed: https://crrev.com/e7609ecb014a46e1472939a43e1336c84007614f Cr-Commit-Position: refs/heads/master@{#38472}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -14 lines) Patch
M src/bootstrapper.cc View 2 chunks +17 lines, -6 lines 0 comments Download
M src/compiler/typer.cc View 3 chunks +30 lines, -7 lines 0 comments Download
M src/objects.h View 3 chunks +9 lines, -1 line 0 comments Download
M src/type-cache.h View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
Benedikt Meurer
4 years, 4 months ago (2016-08-08 18:19:18 UTC) #1
Franzi
lgtm
4 years, 4 months ago (2016-08-09 06:56:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222053002/1
4 years, 4 months ago (2016-08-09 07:11:43 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 07:13:45 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 07:16:18 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e7609ecb014a46e1472939a43e1336c84007614f
Cr-Commit-Position: refs/heads/master@{#38472}

Powered by Google App Engine
This is Rietveld 408576698