Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 222203007: Conversion of more places in Blink to use WebLocalFrame (Closed)

Created:
6 years, 8 months ago by dcheng
Modified:
6 years, 8 months ago
Reviewers:
eseidel
CC:
blink-reviews, jamesr, tzik, nhiroki, abarth-chromium, kinuko, dglazkov+blink, site-isolation-reviews_chromium.org
Visibility:
Public.

Description

Conversion of more places in Blink to use WebLocalFrame I'm breaking up my local mega patch to land in several chunks. This is the Blink portion that's needed to build blink_tests successfully with WebLocalFrame subclassing WebFrame. Overall, the changes are pretty straightforward. One method changed back to taking a WebFrame*. It's not yet clear how we're going to coordinate frame detach for remote frames. Once there's a clear story, I'll update it appropriately. The typedef remains for now, as I work on landing the Chrome bits that depend on this. BUG=346764 R=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170717

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -58 lines) Patch
M Source/web/FrameLoaderClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebDOMFileSystem.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebEmbeddedWorkerImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebEmbeddedWorkerImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebFrameImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebHelperPluginImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebLeakDetector.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebPageSerializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebRange.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebSharedWorkerImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebSharedWorkerImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebTestingSupport.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/tests/FrameLoaderClientImplTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/FrameTestHelpers.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/FrameTestHelpers.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 20 chunks +26 lines, -26 lines 0 comments Download
M Source/web/tests/WebHelperPluginTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/web/tests/WebPageNewSerializerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/WebPluginContainerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/WebViewTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M public/web/WebFrameClient.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dcheng
6 years, 8 months ago (2014-04-02 21:58:22 UTC) #1
eseidel
rslgtm
6 years, 8 months ago (2014-04-02 21:59:25 UTC) #2
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 8 months ago (2014-04-02 22:16:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/222203007/1
6 years, 8 months ago (2014-04-02 22:16:18 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 22:44:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 8 months ago (2014-04-02 22:44:43 UTC) #6
dcheng
6 years, 8 months ago (2014-04-02 23:34:52 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r170717 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698