ui/views/widget/desktop_aura/x11_window_event_filter.h - Issue 222203006: Prevents double-clicks on a tab close button from aslo maximizing the browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/desktop_aura/x11_window_event_filter.h

Issue 222203006: Prevents double-clicks on a tab close button from aslo maximizing the browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address bug in toplevel_window_event_handler Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/views/widget/desktop_aura/desktop_screen_x11_unittest.cc ('K') | « ui/views/widget/desktop_aura/desktop_screen_x11_unittest.cc ('k') | ui/views/widget/desktop_aura/x11_window_event_filter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/widget/desktop_aura/x11_window_event_filter.h

diff --git a/ui/views/widget/desktop_aura/x11_window_event_filter.h b/ui/views/widget/desktop_aura/x11_window_event_filter.h

index 7cc97a187501efe31bb095c4744d40fd6d8c15e9..6fcdde198424f3bddb1cc1f108b656e92201821a 100644

--- a/ui/views/widget/desktop_aura/x11_window_event_filter.h

+++ b/ui/views/widget/desktop_aura/x11_window_event_filter.h

@@ -58,6 +58,13 @@ class VIEWS_EXPORT X11WindowEventFilter : public ui::EventHandler {

// True if |xwindow_| is the current _NET_ACTIVE_WINDOW.

bool is_active_;

+ // The non-client component for the target of a MouseEvent. Mouse events can

+ // be destructive to the window tree, which can cause the component of a

+ // ui::EF_IS_DOUBLE_CLICK event to no longer be the same as that of the

+ // initial click. Acting on a double click should only occur for matching

+ // components.

+ int double_click_component_;

sadrul 2014/04/10 20:49:59 Call this simply |click_component_|. With 'double'

jonross 2014/04/11 16:46:41 Done.

DISALLOW_COPY_AND_ASSIGN(X11WindowEventFilter);

};