Issue 222203005: envsetup: Remove host_arch bitness check, let android_gyp print that it's going away.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 222203005: envsetup: Remove host_arch bitness check, let android_gyp print that it's going away. (Closed)

Created:
6 years, 8 months ago by Nico

Modified:
6 years, 8 months ago

Reviewers:
Yaron

CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

envsetup: Remove host_arch bitness check, let android_gyp print that it's going away. Since it's no longer necessary to source envsetup, having a bitness check in here isn't very useful. Let build/gyp_chromium always pass --check for android so that it behaves the same as android_gyp and let android_gyp print a note that it'll disappear eventually. BUG=330631 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261195

Patch Set 1 #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -18 lines)			Patch
	M	build/android/envsetup.sh	View		2 chunks	+1 line, -18 lines	1 comment	Download
	M	build/gyp_chromium	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Yaron

lgtm https://codereview.chromium.org/222203005/diff/1/build/android/envsetup.sh File build/android/envsetup.sh (right): https://codereview.chromium.org/222203005/diff/1/build/android/envsetup.sh#newcode61 build/android/envsetup.sh:61: echo "Please call build/gyp_chromium instead. android_gyp is going ...

6 years, 8 months ago (2014-04-02 22:04:19 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/222203005/1

6 years, 8 months ago (2014-04-02 22:11:56 UTC) #4

Message was sent while issue was closed.

Change committed as 261195

Expand Messages | Collapse Messages