Pepper: Move exit_status to NexeLoadManager.

Pepper: Move exit_status to NexeLoadManager.

This allows us to take SetReadOnlyProperty out of PPB_NaCl_Private. Hooray.

BUG=236959
R=dmichael@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261447

[dmichael (off chromium), 2014-04-02 19:01:41]

lgtm!

https://codereview.chromium.org/222203003/diff/60001/components/nacl/renderer...
File components/nacl/renderer/ppb_nacl_private_impl.cc (left):

https://codereview.chromium.org/222203003/diff/60001/components/nacl/renderer...
components/nacl/renderer/ppb_nacl_private_impl.cc:592: &SetReadOnlyProperty,
Yay!

https://codereview.chromium.org/222203003/diff/60001/ppapi/native_client/src/...
File ppapi/native_client/src/trusted/plugin/plugin.cc (right):

https://codereview.chromium.org/222203003/diff/60001/ppapi/native_client/src/...
ppapi/native_client/src/trusted/plugin/plugin.cc:814: if (exit_status != -1) {
Pardon the stupid question, but is -1 a viable exit status from a program? It
seems like we're using -1 as an indicator that it's never been set, and I just
want to make sure that actually makes sense.

If -1 is a code we might actually get from a program, we might want to fix it
later so we track whether the exit status has been set separately. (E.g., it
would be easy to fix after all the exit status usage is moved to the renderer).

[teravest, 2014-04-02 19:26:25]

On Wed, Apr 2, 2014 at 1:01 PM,  <dmichael@chromium.org> wrote:
> lgtm!
>
>
>
https://codereview.chromium.org/222203003/diff/60001/components/nacl/renderer...
> File components/nacl/renderer/ppb_nacl_private_impl.cc (left):
>
>
https://codereview.chromium.org/222203003/diff/60001/components/nacl/renderer...
> components/nacl/renderer/ppb_nacl_private_impl.cc:592:
> &SetReadOnlyProperty,
> Yay!
>
>
https://codereview.chromium.org/222203003/diff/60001/ppapi/native_client/src/...
> File ppapi/native_client/src/trusted/plugin/plugin.cc (right):
>
>
https://codereview.chromium.org/222203003/diff/60001/ppapi/native_client/src/...
> ppapi/native_client/src/trusted/plugin/plugin.cc:814: if (exit_status !=
> -1) {
> Pardon the stupid question, but is -1 a viable exit status from a
> program? It seems like we're using -1 as an indicator that it's never
> been set, and I just want to make sure that actually makes sense.
>
> If -1 is a code we might actually get from a program, we might want to
> fix it later so we track whether the exit status has been set
> separately. (E.g., it would be easy to fix after all the exit status
> usage is moved to the renderer).

exit_status should be limited to values 0-0xff in this case.
The value is sent through this macro:
#define NACL_ABI_WEXITSTATUS(status) (((status) & 0xff00) >> 8)

I'll add a comment that "legal" values are 0x00-0xff.

>
> https://codereview.chromium.org/222203003/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[teravest, 2014-04-03 15:29:46]

The CQ bit was checked by teravest@chromium.org

[commit-bot: I haz the power, 2014-04-03 15:29:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/teravest@chromium.org/222203003/90001

[teravest, 2014-04-03 16:47:12]

Committed patchset #6 manually as r261447 (presubmit successful).