chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java - Issue 2222013004: Handle both plural and singular tab switcher content descriptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java

Issue 2222013004: Handle both plural and singular tab switcher content descriptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add string formatting to avoid future ImpliedQuantity lint warnings. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« build/android/lint/suppressions.xml ('K') | « chrome/android/java/res/layout/toolbar.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java

index 3580d89175257cf9d85e861c5224de07e43a97eb..f810b0e5d400d1c747e12912bf181e2b606c569d 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java

@@ -1846,8 +1846,9 @@ public class ToolbarPhone extends ToolbarLayout

mToggleTabStackButton.setEnabled(numberOfTabs >= 1);

mToggleTabStackButton.setContentDescription(

- getResources().getString(R.string.accessibility_toolbar_btn_tabswitcher_toggle,

- numberOfTabs));

+ getResources().getQuantityString(

+ R.plurals.accessibility_toolbar_btn_tabswitcher_toggle,

+ numberOfTabs, numberOfTabs));

mTabSwitcherButtonDrawableLight.updateForTabCount(numberOfTabs, isIncognito());

mTabSwitcherButtonDrawable.updateForTabCount(numberOfTabs, isIncognito());