Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2222013003: MD WebUI: Simplify cr-shared-menu exit animation (Closed)

Created:
4 years, 4 months ago by tsergeant
Modified:
4 years, 4 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-elements_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD WebUI: Simplify cr-shared-menu exit animation The current menu exit animation has the menu fade out while shrinking width and height. However, the shrinking is barely visible and causes visual glitches when quickly closing/reopening the menu. This change does not completely fix either of the linked bugs, but it greatly lessens their effect. BUG=632251, 631840 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/e022b8b94971d07b93ed758b259a0ed31da9a015 Cr-Commit-Position: refs/heads/master@{#410553}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M ui/webui/resources/cr_elements/cr_shared_menu/cr_shared_menu.js View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
tsergeant
PTAL!
4 years, 4 months ago (2016-08-09 01:20:43 UTC) #5
Dan Beam
lgtm
4 years, 4 months ago (2016-08-09 01:44:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222013003/1
4 years, 4 months ago (2016-08-09 02:34:26 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 02:52:31 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 02:54:34 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e022b8b94971d07b93ed758b259a0ed31da9a015
Cr-Commit-Position: refs/heads/master@{#410553}

Powered by Google App Engine
This is Rietveld 408576698