Fixes leak of duplicate command line environment strings

Fixes leak of duplicate command line environment strings

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/82cb63e70f4f7ddd0d74b8f42d9df92f8a1c2579

[zra, 2016-08-08 17:41:46]

zra@google.com changed reviewers:
+ asiva@google.com

[siva, 2016-08-08 19:41:05]

lgtm

https://codereview.chromium.org/2222013002/diff/1/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/2222013002/diff/1/runtime/bin/main.cc#newcode313
runtime/bin/main.cc:313: }
how about

if (entry->value != NULL) {
  free(name);
  free(entry->value);
}
entry->value = value;

[zra, 2016-08-08 19:53:14]

https://codereview.chromium.org/2222013002/diff/1/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/2222013002/diff/1/runtime/bin/main.cc#newcode313
runtime/bin/main.cc:313: }
On 2016/08/08 19:41:05, siva wrote:
> how about
> 
> if (entry->value != NULL) {
>   free(name);
>   free(entry->value);
> }
> entry->value = value;

Done.

[zra, 2016-08-08 19:53:28]

Description was changed from

==========
Fixes leak of duplicate command line environment strings
==========

to

==========
Fixes leak of duplicate command line environment strings

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/82cb63e70f4f7ddd0d74b8f42d9df92f8a1c2579
==========

[zra, 2016-08-08 19:53:30]

Committed patchset #2 (id:20001) manually as
82cb63e70f4f7ddd0d74b8f42d9df92f8a1c2579 (presubmit successful).