Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 2221863002: [turbofan] Slightly improve typing rule for NumberSubtract. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Slightly improve typing rule for NumberSubtract. Properly figure out NaN and -0 cases even for non-integer inputs. This helps to reduce the number of checks we have to perform in case we try to go back to int32 after a floating point operation. R=epertoso@chromium.org Committed: https://crrev.com/288066e50158f44fc4acbdef93270b751bc2c7cb Cr-Commit-Position: refs/heads/master@{#38415}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -15 lines) Patch
M src/compiler/operation-typer.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/operation-typer.cc View 3 chunks +42 lines, -14 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Benedikt Meurer
4 years, 4 months ago (2016-08-08 07:41:02 UTC) #1
Benedikt Meurer
Hey Enrico, This is brining the NumberSubtract rule in line with the others. Please take ...
4 years, 4 months ago (2016-08-08 07:41:58 UTC) #5
epertoso
lgtm
4 years, 4 months ago (2016-08-08 07:50:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2221863002/1
4 years, 4 months ago (2016-08-08 08:00:25 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 08:02:45 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 08:03:21 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/288066e50158f44fc4acbdef93270b751bc2c7cb
Cr-Commit-Position: refs/heads/master@{#38415}

Powered by Google App Engine
This is Rietveld 408576698