Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2221853002: Revert of [Tracing] Embed V8 runtime call stats into tracing. (Closed)

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 4 months ago
CC:
oth, rmcilroy, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [Tracing] Embed V8 runtime call stats into tracing. (patchset #8 id:140001 of https://codereview.chromium.org/2187693002/ ) Reason for revert: Leaks block chromium roll: https://codereview.chromium.org/2219083003/ Example build: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/205435 You can add the trybot from tryserver.chromium.linux, linux_chromium_asan_rel_ng, on reland. Original issue's description: > [Reland][Tracing] Embed V8 runtime call stats into tracing. > > Currently we have V8 RuntimeCallStats that is independently from tracing when > running d8 with flag --runtime_call_stats. This patch embeds V8 runtime call > stats into tracing, by having a global table of runtime call counters each > isolate, resetting the table each time we enter a top level trace event, and > dumping the table for each top level trace event. This will make trace file more > compat, as well as enable runtime call stats in tracing system. > > This patch adds ~5% overhead to V8 when the category is enabled, we measure the > overhead by running a script when category is enabled. > > BUG=v8:5089 > > Committed: https://crrev.com/d014866173eaa2b548c566217b2c94b1d49385fa > Committed: https://crrev.com/1ca3b73bba4a7253ca8eeef39321d70e7d414331 > Committed: https://crrev.com/3f936a5b17754783e92d2146eaf66c88a78ee45b > Cr-Original-Original-Commit-Position: refs/heads/master@{#38270} > Cr-Original-Commit-Position: refs/heads/master@{#38314} > Cr-Commit-Position: refs/heads/master@{#38403} TBR=cbruni@chromium.org,fmeawad@chromium.org,bmeurer@chromium.org,adamk@chromium.org,rmcilroy@chromium.org,lpy@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:5089 NOTRY=true NOPRESUBMIT=true Committed: https://crrev.com/12ee7ec0a80c8383304f2b39b2a4d038593e3542 Cr-Commit-Position: refs/heads/master@{#38412}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -403 lines) Patch
M src/api.cc View 10 chunks +6 lines, -16 lines 0 comments Download
M src/api-arguments.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M src/api-arguments-inl.h View 5 chunks +0 lines, -11 lines 0 comments Download
M src/arguments.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/builtins/builtins-utils.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/compiler.cc View 10 chunks +16 lines, -22 lines 0 comments Download
M src/counters.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/counters.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/d8.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M src/deoptimizer.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M src/execution.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ic/ic.cc View 15 chunks +15 lines, -0 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/isolate.h View 3 chunks +0 lines, -5 lines 0 comments Download
M src/lookup.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/objects.cc View 3 chunks +0 lines, -14 lines 0 comments Download
M src/parsing/parser.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/tracing/trace-event.h View 4 chunks +0 lines, -171 lines 0 comments Download
M src/tracing/trace-event.cc View 1 chunk +0 lines, -120 lines 0 comments Download
M src/v8.gyp View 4 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Achenbach
Created Revert of [Tracing] Embed V8 runtime call stats into tracing.
4 years, 4 months ago (2016-08-08 06:45:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2221853002/1
4 years, 4 months ago (2016-08-08 06:46:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2221853002/1
4 years, 4 months ago (2016-08-08 07:08:03 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 07:08:25 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 07:10:19 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12ee7ec0a80c8383304f2b39b2a4d038593e3542
Cr-Commit-Position: refs/heads/master@{#38412}

Powered by Google App Engine
This is Rietveld 408576698