Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1760)

Unified Diff: chrome/browser/metrics/chrome_metrics_services_manager_client.h

Issue 2221833005: Adding support for sampling crashes in Chrome on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rkaplow's comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/chrome_metrics_services_manager_client.h
diff --git a/chrome/browser/metrics/chrome_metrics_services_manager_client.h b/chrome/browser/metrics/chrome_metrics_services_manager_client.h
index 4979e96c6403f4f549ccba98052b978b881d7d8b..32030a62e903f0a50ecd428471278b7e6d8f378b 100644
--- a/chrome/browser/metrics/chrome_metrics_services_manager_client.h
+++ b/chrome/browser/metrics/chrome_metrics_services_manager_client.h
@@ -55,6 +55,11 @@ class ChromeMetricsServicesManagerClient
bool IsMetricsReportingEnabled() override;
bool OnlyDoMetricsRecording() override;
+#if defined(OS_WIN)
+ // On Windows, the client controls if crashpad can upload crash reports.
Mark Mentovai 2016/08/11 18:32:25 Crashpad, proper name, capital C
Mark Mentovai 2016/08/11 18:32:25 if→whether
jwd 2016/08/11 21:41:03 Done.
jwd 2016/08/11 21:41:03 Done.
+ void UpdateRunningServices(bool may_record, bool may_upload) override;
+#endif // defined(OS_WIN)
+
// Gets the MetricsStateManager, creating it if it has not already been
// created.
metrics::MetricsStateManager* GetMetricsStateManager();

Powered by Google App Engine
This is Rietveld 408576698