chrome/browser/metrics/chrome_metrics_services_manager_client.h - Issue 2221833005: Adding support for sampling crashes in Chrome on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/chrome_metrics_services_manager_client.h

Issue 2221833005: Adding support for sampling crashes in Chrome on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding support for sampling crashes in Chrome on Windows. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/app/chrome_crash_reporter_client_win.cc ('k') | chrome/browser/metrics/chrome_metrics_services_manager_client.cc » ('j') | chrome/browser/metrics/chrome_metrics_services_manager_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/chrome_metrics_services_manager_client.h

diff --git a/chrome/browser/metrics/chrome_metrics_services_manager_client.h b/chrome/browser/metrics/chrome_metrics_services_manager_client.h

index 4979e96c6403f4f549ccba98052b978b881d7d8b..c3b9ec35d5c7baa8a293b7c3a99b1d460f7af0cf 100644

--- a/chrome/browser/metrics/chrome_metrics_services_manager_client.h

+++ b/chrome/browser/metrics/chrome_metrics_services_manager_client.h

@@ -55,6 +55,11 @@ class ChromeMetricsServicesManagerClient

bool IsMetricsReportingEnabled() override;

bool OnlyDoMetricsRecording() override;

+#if defined(OS_WIN)

+ // On windows, the client controls if crashpad can upload crash reports.

rkaplow 2016/08/10 20:16:28 nit: Windows

jwd 2016/08/10 22:10:02 Done.

+ void UpdateRunningServices(bool may_record, bool may_upload) override;

+#endif // defined(OS_WIN)

// Gets the MetricsStateManager, creating it if it has not already been

// created.

metrics::MetricsStateManager* GetMetricsStateManager();