Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5997)

Unified Diff: chrome/install_static/install_util.cc

Issue 2221833005: Adding support for sampling crashes in Chrome on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: scottmg's comments, adding DCHECK Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/install_static/install_util.h ('k') | components/crash/content/app/crash_reporter_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/install_static/install_util.cc
diff --git a/chrome/install_static/install_util.cc b/chrome/install_static/install_util.cc
index c31b90e8927cd71f4cedf026d3b44da0f2112046..3d49274552d945749152275fd1fd80e6f69ed456 100644
--- a/chrome/install_static/install_util.cc
+++ b/chrome/install_static/install_util.cc
@@ -87,6 +87,14 @@ const wchar_t kBrowserCrashDumpMetricsSubKey[] = L"\\BrowserCrashDumpAttempts";
const wchar_t kRegPathGoogleUpdate[] = L"Software\\Google\\Update";
const wchar_t kRegGoogleUpdateVersion[] = L"version";
+// Registry key to store the stats/crash sampling state of Chrome. If set to 1,
+// stats and crash reports will be uploaded in line with the user's consent,
+// otherwise, uploads will be disabled. It is used to sample clients, to reduce
+// server load for metics and crashes. This is controlled by the
+// MetricsReporting feature in chrome_metrics_services_manager_client.cc and is
+// written when metrics services are started up and when consent changes.
+const wchar_t kRegValueChromeStatsSample[] = L"UsageStatsInSample";
+
void Trace(const wchar_t* format_string, ...) {
static const int kMaxLogBufferSize = 1024;
static wchar_t buffer[kMaxLogBufferSize] = {};
@@ -234,6 +242,12 @@ bool RecursiveDirectoryCreate(const std::wstring& full_path) {
return true;
}
+std::wstring GetChromeInstallRegistryPath() {
+ std::wstring registry_path = L"Software\\";
+ registry_path += GetChromeInstallSubDirectory();
+ return registry_path;
+}
+
bool GetCollectStatsConsentImpl(const std::wstring& exe_path) {
bool enabled = true;
bool controlled_by_policy = ReportingIsEnforcedByPolicy(&enabled);
@@ -412,6 +426,33 @@ bool GetCollectStatsConsentForTesting(const std::wstring& exe_path) {
return GetCollectStatsConsentImpl(exe_path);
}
+bool GetCollectStatsInSample() {
+ std::wstring registry_path = GetChromeInstallRegistryPath();
+
+ DWORD out_value = 0;
+ if (!nt::QueryRegValueDWORD(nt::HKCU, registry_path.c_str(),
+ kRegValueChromeStatsSample, &out_value)) {
+ // If reading the value failed, treat it as though sampling isn't in effect,
+ // implicitly meaning this install is in the sample.
+ return true;
+ }
+ return out_value == 1;
+}
+
+bool SetCollectStatsInSample(bool in_sample) {
+ std::wstring registry_path = GetChromeInstallRegistryPath();
+
+ HANDLE key_handle = INVALID_HANDLE_VALUE;
+ if (!nt::CreateRegKey(nt::HKCU, registry_path.c_str(), KEY_SET_VALUE,
+ &key_handle)) {
+ nt::CloseRegKey(key_handle);
+ return false;
+ }
+
+ return nt::SetRegValueDWORD(key_handle, kRegValueChromeStatsSample,
+ in_sample ? 1 : 0);
+}
+
bool ReportingIsEnforcedByPolicy(bool* metrics_is_enforced_by_policy) {
DWORD value = 0;
@@ -678,8 +719,7 @@ std::wstring GetChromeInstallSubDirectory() {
}
std::wstring GetBrowserCrashDumpAttemptsRegistryPath() {
- std::wstring registry_path = L"Software\\";
- registry_path += GetChromeInstallSubDirectory();
+ std::wstring registry_path = GetChromeInstallRegistryPath();
registry_path += kBrowserCrashDumpMetricsSubKey;
return registry_path;
}
« no previous file with comments | « chrome/install_static/install_util.h ('k') | components/crash/content/app/crash_reporter_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698