Adding support for sampling crashes in Chrome on Windows.

components/crash/content/app/crashpad.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_CRASH_CONTENT_APP_CRASHPAD_H_
 #define COMPONENTS_CRASH_CONTENT_APP_CRASHPAD_H_
 
 #include <time.h>
 
 #include <map>
@@ skipping 43 matching lines @@
 void InitializeCrashpad(bool initial_client, const std::string& process_type);
 
 #if defined(OS_WIN)
 // This is the same as InitializeCrashpad(), but rather than launching a
 // crashpad_handler executable, relaunches the current executable with a command
 // line argument of --type=crashpad-handler.
 void InitializeCrashpadWithEmbeddedHandler(bool initial_client,
                                            const std::string& process_type);
 #endif  // OS_WIN
 
-// Enables or disables crash report upload. This is a property of the Crashpad
-// database. In a newly-created database, uploads will be disabled. This
-// function only has an effect when called in the browser process. Its effect is
-// immediate and applies to all other process types, including processes that
-// are already running.
-void SetUploadsEnabled(bool enabled);
+// Enables or disables crash report upload, taking the given consent to upload
+// into account. Consent may be ignored, uploads may not be enabled even with
+// consent, but vill only be enabled without consent when policy enforces crash

[Mark Mentovai, 2016/08/17 20:59:07]

vill → will

[jwd, 2016/08/17 21:55:59]

Done.

+// reporting. Enable or disable crash report upload is a property of the

[Mark Mentovai, 2016/08/17 20:59:07]

Whether report upload is enabled is a property

[jwd, 2016/08/17 21:55:59]

Done.

+// Crashpad database. In a newly- created database, uploads will be disabled.

[Mark Mentovai, 2016/08/17 20:59:07]

Remove the newly- introduced space after the dash.

[jwd, 2016/08/17 21:55:59]

Done.

+// This function only has an effect when called in the browser process. Its
+// effect is immediate and applies to all other process types, including
+// processes that are already running.
+void UpdateUploadsEnabled(bool consent);

[Mark Mentovai, 2016/08/17 20:59:07]

I don’t know that this name is any better than SetUploadsEnabled (and I’m afraid
it might be worse), but if everyone else likes it, OK…

My concern is that if you want to update this thing to reflect that it’s about
consent, then you need to put the word “consent” in the function name, because
nobody sees this “consent” parameter name at call sites.

So maybe SetUploadConsent()?

[jwd, 2016/08/17 21:55:59]

Done.

 
 // Determines whether uploads are enabled or disabled. This information is only
 // available in the browser process.
 bool GetUploadsEnabled();
 
 enum class ReportUploadState {
   NotUploaded,
   Pending,
   Uploaded,
 };
@@ skipping 37 matching lines @@
 // Returns the database path, if initializing in the browser process.
 base::FilePath PlatformCrashpadInitialization(bool initial_client,
                                               bool browser_process,
                                               bool embedded_handler);
 
 }  // namespace internal
 
 }  // namespace crash_reporter
 
 #endif  // COMPONENTS_CRASH_CONTENT_APP_CRASHPAD_H_