Adding support for sampling crashes in Chrome on Windows.

components/crash/content/app/crashpad.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/crash/content/app/crashpad.h"
 
 #include <stddef.h>
 #include <string.h>
 
 #if BUILDFLAG(ENABLE_KASKO)
@@ skipping 246 matching lines @@
 #elif defined(OS_WIN)
   // On Windows, we want both the browser process and the installer and any
   // other "main, first process" to initialize things. There is no "relauncher"
   // on Windows, so this is synonymous with initial_client.
   const bool should_initialize_database_and_set_upload_policy = initial_client;
 #endif
   if (should_initialize_database_and_set_upload_policy) {
     g_database =
         crashpad::CrashReportDatabase::Initialize(database_path).release();
 
-    bool enable_uploads = false;
-    if (!crash_reporter_client->ReportingIsEnforcedByPolicy(&enable_uploads)) {
-      // Breakpad provided a --disable-breakpad switch to disable crash dumping
-      // (not just uploading) here. Crashpad doesn't need it: dumping is enabled
-      // unconditionally and uploading is gated on consent, which tests/bots
-      // shouldn't have. As a precaution, uploading is also disabled on bots
-      // even if consent is present.
-      enable_uploads = crash_reporter_client->GetCollectStatsConsent() &&
-                       !crash_reporter_client->IsRunningUnattended();
-    }
-
-    SetUploadsEnabled(enable_uploads);
+    UpdateUploadsEnabled(crash_reporter_client->GetCollectStatsConsent());
   }
 }
 
 }  // namespace
 
 void InitializeCrashpad(bool initial_client, const std::string& process_type) {
   InitializeCrashpadImpl(initial_client, process_type, false);
 }
 
 #if defined(OS_WIN)
 void InitializeCrashpadWithEmbeddedHandler(bool initial_client,
                                            const std::string& process_type) {
   InitializeCrashpadImpl(initial_client, process_type, true);
 }
 #endif  // OS_WIN
 
-void SetUploadsEnabled(bool enable_uploads) {
+void UpdateUploadsEnabled(bool consent) {
   if (g_database) {

[Alexei Svitkine (slow), 2016/08/17 20:37:48]

Nit: Early return instead.

[jwd, 2016/08/17 21:55:59]

Done.

+    bool enable_uploads = false;
+    CrashReporterClient* crash_reporter_client = GetCrashReporterClient();
+    if (!crash_reporter_client->ReportingIsEnforcedByPolicy(&enable_uploads)) {
+        // Breakpad provided a --disable-breakpad switch to disable crash

[Mark Mentovai, 2016/08/17 20:59:07]

What’s up with this indentation?

[jwd, 2016/08/17 21:55:59]

Done.

+        // dumping (not just uploading) here. Crashpad doesn't need it: dumping
+        // is enabled unconditionally and uploading is gated on consent, which
+        // tests/bots shouldn't have. As a precaution, uploading is also
+        // disabled on bots even if consent is present.
+        enable_uploads = consent &&
+                         !crash_reporter_client->IsRunningUnattended();
+      }

[Alexei Svitkine (slow), 2016/08/17 20:37:48]

Nit: Indent is off. Run git cl format.

[jwd, 2016/08/17 21:55:59]

Done.

+
+

[Alexei Svitkine (slow), 2016/08/17 20:37:48]

Nit: Remove extra blank line.

[jwd, 2016/08/17 21:55:59]

Done.

     crashpad::Settings* settings = g_database->GetSettings();
-    settings->SetUploadsEnabled(enable_uploads);
+    settings->SetUploadsEnabled(
+        enable_uploads && crash_reporter_client->GetCollectStatsInSample());
   }
 }
 
 bool GetUploadsEnabled() {
   if (g_database) {
     crashpad::Settings* settings = g_database->GetSettings();
     bool enable_uploads;
     if (settings->GetUploadsEnabled(&enable_uploads)) {
       return enable_uploads;
     }
@@ skipping 144 matching lines @@
 }
 
 #endif  // BUILDFLAG(ENABLE_KASKO)
 
 }  // namespace crash_reporter
 
 #if defined(OS_WIN)
 
 extern "C" {
 
+// This function is used in chrome_metrics_services_manager_client.cc to trigger
+// changes to the upload-enabled state. This is done when the metrics services
+// are initialized, and when the user changes their consent for uploads. See
+// crash_reporter::UpdateUploadsEnabled for effects.
+void __declspec(dllexport) __cdecl UpdateUploadsEnabledImpl(bool consent) {
+  crash_reporter::UpdateUploadsEnabled(consent);
+}
+
 // NOTE: This function is used by SyzyASAN to annotate crash reports. If you
 // change the name or signature of this function you will break SyzyASAN
 // instrumented releases of Chrome. Please contact syzygy-team@chromium.org
 // before doing so! See also http://crbug.com/567781.
 void __declspec(dllexport) __cdecl SetCrashKeyValueImpl(const wchar_t* key,
                                                         const wchar_t* value) {
   crash_reporter::SetCrashKeyValue(base::UTF16ToUTF8(key),
                                    base::UTF16ToUTF8(value));
 }
 
 void __declspec(dllexport) __cdecl ClearCrashKeyValueImpl(const wchar_t* key) {
   crash_reporter::ClearCrashKey(base::UTF16ToUTF8(key));
 }
 
 }  // extern "C"
 
 #endif  // OS_WIN