Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2221833003: Remove WTF::toASCIILowerUnchecked. (Closed)

Created:
4 years, 4 months ago by esprehn
Modified:
4 years, 4 months ago
Reviewers:
haraken, Yuta Kitamura
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-html_chromium.org, blink-reviews-wtf_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, dglazkov+blink, kinuko+watch, kozyatinskiy+blink_chromium.org, loading-reviews+parser_chromium.org, lushnikov+blink_chromium.org, Mikhail, pfeldman+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WTF::toASCIILowerUnchecked. The caller in the inspector is dead code, and XSSAuditor can use equalIgnoringASCIICase + StringView instead. Committed: https://crrev.com/a4ebb5b1ce91fc774c51f2fbd1cf976d6eadd96a Cr-Commit-Position: refs/heads/master@{#410583}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -27 lines) Patch
M third_party/WebKit/Source/core/html/parser/XSSAuditor.cpp View 1 chunk +5 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/String16STL.cpp View 1 chunk +0 lines, -8 lines 1 comment Download
M third_party/WebKit/Source/wtf/ASCIICType.h View 3 chunks +1 line, -12 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
esprehn
4 years, 4 months ago (2016-08-09 01:45:45 UTC) #6
esprehn
https://codereview.chromium.org/2221833003/diff/1/third_party/WebKit/Source/platform/inspector_protocol/String16STL.cpp File third_party/WebKit/Source/platform/inspector_protocol/String16STL.cpp (left): https://codereview.chromium.org/2221833003/diff/1/third_party/WebKit/Source/platform/inspector_protocol/String16STL.cpp#oldcode116 third_party/WebKit/Source/platform/inspector_protocol/String16STL.cpp:116: template<typename CharType> inline bool isASCIIAlphaCaselessEqual(CharType cssCharacter, char character) This ...
4 years, 4 months ago (2016-08-09 01:46:11 UTC) #7
haraken
LGTM
4 years, 4 months ago (2016-08-09 02:10:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2221833003/1
4 years, 4 months ago (2016-08-09 02:17:13 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 05:20:37 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 05:22:22 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a4ebb5b1ce91fc774c51f2fbd1cf976d6eadd96a
Cr-Commit-Position: refs/heads/master@{#410583}

Powered by Google App Engine
This is Rietveld 408576698