Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: src/code-stubs.h

Issue 2221833002: [Interpreter] Collect type feedback for subtract operation and pass it to turbofan. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments from Ross. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/code-stubs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index 17b193e748e0fbd92537980d8a0305fe46b090e7..251446ba301173688bbcc0e534af5c98fb18de2a 100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -122,6 +122,7 @@ namespace internal {
V(StringLength) \
V(Add) \
V(Subtract) \
+ V(SubtractWithFeedback) \
V(Multiply) \
V(Divide) \
V(Modulus) \
@@ -432,6 +433,20 @@ class CodeStub BASE_EMBEDDED {
} \
DEFINE_CODE_STUB(NAME, SUPER)
+#define DEFINE_TURBOFAN_BINARY_OP_CODE_STUB_WITH_FEEDBACK(NAME, SUPER) \
+ public: \
+ static compiler::Node* Generate( \
+ CodeStubAssembler* assembler, compiler::Node* left, \
+ compiler::Node* right, compiler::Node* context, \
+ compiler::Node* type_feedback_vector, compiler::Node* slot_id); \
+ void GenerateAssembly(CodeStubAssembler* assembler) const override { \
+ assembler->Return( \
+ Generate(assembler, assembler->Parameter(0), assembler->Parameter(1), \
+ assembler->Parameter(2), assembler->Parameter(3), \
+ assembler->Parameter(4))); \
+ } \
+ DEFINE_CODE_STUB(NAME, SUPER)
+
#define DEFINE_TURBOFAN_UNARY_OP_CODE_STUB(NAME, SUPER) \
public: \
static compiler::Node* Generate(CodeStubAssembler* assembler, \
@@ -749,6 +764,16 @@ class SubtractStub final : public TurboFanCodeStub {
DEFINE_TURBOFAN_BINARY_OP_CODE_STUB(Subtract, TurboFanCodeStub);
};
+class SubtractWithFeedbackStub final : public TurboFanCodeStub {
+ public:
+ explicit SubtractWithFeedbackStub(Isolate* isolate)
+ : TurboFanCodeStub(isolate) {}
+
+ DEFINE_CALL_INTERFACE_DESCRIPTOR(BinaryOp);
+ DEFINE_TURBOFAN_BINARY_OP_CODE_STUB_WITH_FEEDBACK(SubtractWithFeedback,
+ TurboFanCodeStub);
+};
+
class MultiplyStub final : public TurboFanCodeStub {
public:
explicit MultiplyStub(Isolate* isolate) : TurboFanCodeStub(isolate) {}
« no previous file with comments | « no previous file | src/code-stubs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698