[Interpreter] Collect type feedback for subtract operation and pass it to turbofan.

src/code-stubs.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_CODE_STUBS_H_
 #define V8_CODE_STUBS_H_
 
 #include "src/allocation.h"
 #include "src/assembler.h"
 #include "src/code-stub-assembler.h"
 #include "src/codegen.h"
 #include "src/globals.h"
 #include "src/ic/ic-state.h"
 #include "src/interface-descriptors.h"
 #include "src/macro-assembler.h"
 #include "src/ostreams.h"
+#include "src/utils.h"
 
 namespace v8 {
 namespace internal {
 
 // List of code stubs used on all platforms.
 #define CODE_STUB_LIST_ALL_PLATFORMS(V)       \
   /* --- PlatformCodeStubs --- */             \
   V(ArrayConstructor)                         \
   V(BinaryOpICWithAllocationSite)             \
   V(CallApiCallback)                          \
@@ skipping 398 matching lines @@
   static compiler::Node* Generate(CodeStubAssembler* assembler,                \
                                   compiler::Node* left, compiler::Node* right, \
                                   compiler::Node* context);                    \
   void GenerateAssembly(CodeStubAssembler* assembler) const override {         \
     assembler->Return(Generate(assembler, assembler->Parameter(0),             \
                                assembler->Parameter(1),                        \
                                assembler->Parameter(2)));                      \
   }                                                                            \
   DEFINE_CODE_STUB(NAME, SUPER)
 
+// TODO(mythria): check where generate assembly is used and if have to pass 6
+// parameters.
+#define DEFINE_TURBOFAN_BINARY_OP_CODE_STUB_WITH_FEEDBACK(NAME, SUPER)         \
+ public:                                                                       \
+  static compiler::Node* Generate(CodeStubAssembler* assembler,                \
+                                  compiler::Node* left, compiler::Node* right, \
+                                  compiler::Node* context,                     \
+                                  compiler::Node* type_feedback_vector = NULL, \
+                                  compiler::Node* slot_id = NULL);             \
+  void GenerateAssembly(CodeStubAssembler* assembler) const override {         \

[mythria, 2016/08/08 04:33:56]

I am not sure where GenerateAssembly is used. I did not add two additional
parameters because we collect type feedback only from ignition and others don't
require to collect type feedback. 

+    assembler->Return(Generate(assembler, assembler->Parameter(0),             \
+                               assembler->Parameter(1),                        \
+                               assembler->Parameter(2)));                      \
+  }                                                                            \
+  DEFINE_CODE_STUB(NAME, SUPER)
+
 #define DEFINE_TURBOFAN_UNARY_OP_CODE_STUB(NAME, SUPER)                \
  public:                                                               \
   static compiler::Node* Generate(CodeStubAssembler* assembler,        \
                                   compiler::Node* value,               \
                                   compiler::Node* context);            \
   void GenerateAssembly(CodeStubAssembler* assembler) const override { \
     assembler->Return(Generate(assembler, assembler->Parameter(0),     \
                                assembler->Parameter(1)));              \
   }                                                                    \
   DEFINE_CODE_STUB(NAME, SUPER)
@@ skipping 294 matching lines @@
 
   DEFINE_CALL_INTERFACE_DESCRIPTOR(BinaryOp);
   DEFINE_TURBOFAN_BINARY_OP_CODE_STUB(Add, TurboFanCodeStub);
 };
 
 class SubtractStub final : public TurboFanCodeStub {
  public:
   explicit SubtractStub(Isolate* isolate) : TurboFanCodeStub(isolate) {}
 
   DEFINE_CALL_INTERFACE_DESCRIPTOR(BinaryOp);
-  DEFINE_TURBOFAN_BINARY_OP_CODE_STUB(Subtract, TurboFanCodeStub);
+  DEFINE_TURBOFAN_BINARY_OP_CODE_STUB_WITH_FEEDBACK(Subtract, TurboFanCodeStub);

[mythria, 2016/08/08 04:33:56]

We can remove this once we migrate all binary ops to collect type feedback. 

 };
 
 class MultiplyStub final : public TurboFanCodeStub {
  public:
   explicit MultiplyStub(Isolate* isolate) : TurboFanCodeStub(isolate) {}
 
   DEFINE_CALL_INTERFACE_DESCRIPTOR(BinaryOp);
   DEFINE_TURBOFAN_BINARY_OP_CODE_STUB(Multiply, TurboFanCodeStub);
 };
 
@@ skipping 2376 matching lines @@
 #undef DEFINE_HYDROGEN_CODE_STUB
 #undef DEFINE_CODE_STUB
 #undef DEFINE_CODE_STUB_BASE
 
 extern Representation RepresentationFromType(Type* type);
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_CODE_STUBS_H_