Send orientation and display mode from Web Manifest to WebAPK server

Send orientation and display mode from Web Manifest to WebAPK server

This CL also introduces manifest_util.* with methods for converting
blink::WebDisplayMode and blink::WebScreenOrientationLockType to and from string

BUG=619739
R=mlamouri,sievers
TBR=yfriedman

Committed: https://crrev.com/f51f3c280f6f1fd180eb70581720bd1357f99a93
Cr-Commit-Position: refs/heads/master@{#410768}

[pkotwicz, 2016-08-08 03:33:15]

Description was changed from

==========
Send orientation and display mode from Web Manifest to WebAPK server

This CL also introduces manifest_util.h with methods for converting
blink::WebDisplayMode and blink::WebScreenOrientationLockType to and from string

BUG=619739
==========

to

==========
Send orientation and display mode from Web Manifest to WebAPK server

This CL also introduces manifest_util.* with methods for converting
blink::WebDisplayMode and blink::WebScreenOrientationLockType to and from string

BUG=619739
==========

[pkotwicz, 2016-08-08 03:41:21]

pkotwicz@chromium.org changed reviewers:
+ mlamouri@chromium.org, sievers@chromium.org

[pkotwicz, 2016-08-08 03:41:22]

mlamouri@ can you please take a look? The CL is a subset of
https://codereview.chromium.org/2223443002/ (I took the content/ changes out of
that CL). Do you think that the functions in manifest_util.h belong in blink?
e.g. third_party/WebKit/public/platform/WebDisplayModeUtil.h and
third_party/WebKit/public/platform/modules/screen_orientation/WebScreenOrientationUtil.h

I am asking you because you are the OWNER of
third_party/WebKit/public/platform/modules/screen_orientation

According to sievers@:
>> Feels every so slightly odd that the content public api exposes these blink
>> enum<->string helper (and not for example Blink itself). But then again, the
>> types are exposed a lot in the content-public api here, so also not totally
>> unreasonable.
>> 
>> But then it's probably also not a huge deal for it to exist in the context of
>> the manifest api here.
>>
>> I should also point out this from the content-api guide
>> (https://www.chromium.org/developers/content-module/content-api):
>> 
>> "content/public should contain only interfaces, structs and (rarely) static
>> functions".
>> 
>> Which is of course in this case not a definite recommendation or even rule :)

[mlamouri (slow - plz ping), 2016-08-08 09:46:06]

lgtm, assuming it's an unchanged cut from the larger CL.

Regarding moving this to Blink, I'm not a partisan of moving things unless we
need to. It seems that the usage of these methods are outside of Blink at the
moment. It might make sense to make it to Blink if we need to at a later point.

[pkotwicz, 2016-08-08 14:23:34]

sievers@: Whose opinion did you want with respect to whether the functions in
manifest_util.* belong in blink?

[no sievers, 2016-08-08 18:19:01]

lgtm

[pkotwicz, 2016-08-09 15:07:09]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2016-08-09 15:07:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 15:13:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 15:13:20]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pkotwicz, 2016-08-09 17:15:28]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2016-08-09 17:15:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
sievers@chromium.org, mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/2221823002/#ps20001
(title: "Merge branch 'master' into webapk_builder_impl22")

[commit-bot: I haz the power, 2016-08-09 17:16:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 17:22:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 17:22:19]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pkotwicz, 2016-08-09 18:49:16]

Description was changed from

==========
Send orientation and display mode from Web Manifest to WebAPK server

This CL also introduces manifest_util.* with methods for converting
blink::WebDisplayMode and blink::WebScreenOrientationLockType to and from string

BUG=619739
==========

to

==========
Send orientation and display mode from Web Manifest to WebAPK server

This CL also introduces manifest_util.* with methods for converting
blink::WebDisplayMode and blink::WebScreenOrientationLockType to and from string

BUG=619739
R=mlamouri,sievers
TBR=yfriedman
==========

[pkotwicz, 2016-08-09 18:49:16]

pkotwicz@chromium.org changed reviewers:
+ yfriedman@chromium.org

[pkotwicz, 2016-08-09 18:49:22]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2016-08-09 18:49:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yaron, 2016-08-09 19:05:19]

On 2016/08/09 18:49:57, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

lgtm

[commit-bot: I haz the power, 2016-08-09 19:44:10]

Description was changed from

==========
Send orientation and display mode from Web Manifest to WebAPK server

This CL also introduces manifest_util.* with methods for converting
blink::WebDisplayMode and blink::WebScreenOrientationLockType to and from string

BUG=619739
R=mlamouri,sievers
TBR=yfriedman
==========

to

==========
Send orientation and display mode from Web Manifest to WebAPK server

This CL also introduces manifest_util.* with methods for converting
blink::WebDisplayMode and blink::WebScreenOrientationLockType to and from string

BUG=619739
R=mlamouri,sievers
TBR=yfriedman
==========

[commit-bot: I haz the power, 2016-08-09 19:44:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-09 19:46:27]

Description was changed from

==========
Send orientation and display mode from Web Manifest to WebAPK server

This CL also introduces manifest_util.* with methods for converting
blink::WebDisplayMode and blink::WebScreenOrientationLockType to and from string

BUG=619739
R=mlamouri,sievers
TBR=yfriedman
==========

to

==========
Send orientation and display mode from Web Manifest to WebAPK server

This CL also introduces manifest_util.* with methods for converting
blink::WebDisplayMode and blink::WebScreenOrientationLockType to and from string

BUG=619739
R=mlamouri,sievers
TBR=yfriedman

Committed: https://crrev.com/f51f3c280f6f1fd180eb70581720bd1357f99a93
Cr-Commit-Position: refs/heads/master@{#410768}
==========

[commit-bot: I haz the power, 2016-08-09 19:46:29]

Patchset 2 (id:??) landed as
https://crrev.com/f51f3c280f6f1fd180eb70581720bd1357f99a93
Cr-Commit-Position: refs/heads/master@{#410768}