Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1497)

Issue 2221793004: Fixed crash with zero/infinite aspect ratio radial gradients (Closed)

Created:
4 years, 4 months ago by sashab
Modified:
4 years, 4 months ago
Reviewers:
meade_UTC10, rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed crash with zero/infinite aspect ratio radial gradients BUG=630569, 635727 Committed: https://crrev.com/12e75eb8410fa67bea37acf432f60c191156dea0 Cr-Commit-Position: refs/heads/master@{#410989}

Patch Set 1 #

Patch Set 2 : Added layout test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/gradients/css3-radial-gradients-zero-radius-crash.html View 1 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSGradientValue.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
sashab
4 years, 4 months ago (2016-08-08 05:26:50 UTC) #2
meade_UTC10
c++ code lgtm, but you need to add a test! :)
4 years, 4 months ago (2016-08-08 06:32:29 UTC) #3
sashab
Thanks eddy! :) Added the LayoutTest and referenced the tracking bug for degenerate radial gradients ...
4 years, 4 months ago (2016-08-09 03:11:27 UTC) #5
meade_UTC10
lgtm
4 years, 4 months ago (2016-08-09 04:25:34 UTC) #6
sashab
rune@ for owners :)
4 years, 4 months ago (2016-08-09 04:31:12 UTC) #8
rune
lgtm
4 years, 4 months ago (2016-08-09 08:07:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2221793004/20001
4 years, 4 months ago (2016-08-09 23:49:57 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/270536)
4 years, 4 months ago (2016-08-10 02:25:47 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2221793004/20001
4 years, 4 months ago (2016-08-10 03:11:02 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-10 07:03:01 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 07:04:30 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/12e75eb8410fa67bea37acf432f60c191156dea0
Cr-Commit-Position: refs/heads/master@{#410989}

Powered by Google App Engine
This is Rietveld 408576698