Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2221783005: Remove unused Scope::inside_with() accessor (Closed)

Created:
4 years, 4 months ago by adamk
Modified:
4 years, 4 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove unused Scope::inside_with() accessor scope_inside_with_ itself is still used internally during analysis. R=verwaest@chromium.org Committed: https://crrev.com/42cc6c051e87f1f62178a6fb32e23655b388ea4b Cr-Commit-Position: refs/heads/master@{#38459}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M src/ast/scopes.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
adamk
4 years, 4 months ago (2016-08-08 19:50:15 UTC) #1
Toon Verwaest
lgtm
4 years, 4 months ago (2016-08-08 19:52:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2221783005/1
4 years, 4 months ago (2016-08-08 19:53:11 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 20:15:51 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 20:20:34 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42cc6c051e87f1f62178a6fb32e23655b388ea4b
Cr-Commit-Position: refs/heads/master@{#38459}

Powered by Google App Engine
This is Rietveld 408576698