Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2221783003: Introduce FrameSelection::nodeChildrenWillBeRemoved() (Closed)

Created:
4 years, 4 months ago by yosin_UTC9
Modified:
4 years, 4 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce FrameSelection::nodeChildrenWillBeRemoved() This patch introduces |FrameSelection::nodeChildrenWillBeRemoved()| to process removing children once for container node rather than calling |FrameSelection::nodeWillBeRemoved()| for each descendant nodes in container to improve execution speed of callers of |ContainerNode::removeChildren()|, e.g. |innserHTML| setter, |innerText| setter, etc. After this patch execution speeof is O(1) instead of O(n), where n is number of descendant nodes in container. Updating test expectations of "svg/custom/use-clipped-hit.svg" is caused by difference of selection paint invalidation. From this patch, selection paint invalidation is done by children removal rather than caused by selected nodes. BUG=139552, 632333 TEST=PerformanceTests/DOM/inner_html_with_selection.html Committed: https://crrev.com/6ffa8394ec09cac47f842e47f843ad13dc25feb2 Cr-Commit-Position: refs/heads/master@{#410976}

Patch Set 1 : 2016-08-08T17:35:38 #

Patch Set 2 : 2016-08-09T13:35:17 #

Patch Set 3 : 2016-08-10T10:37:48 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/PerformanceTests/DOM/inner_html_with_selection.html View 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (21 generated)
yosin_UTC9
PTAL
4 years, 4 months ago (2016-08-10 05:45:16 UTC) #19
tkent
lgtm
4 years, 4 months ago (2016-08-10 06:05:26 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2221783003/40001
4 years, 4 months ago (2016-08-10 06:07:54 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-10 06:11:49 UTC) #24
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 06:12:56 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6ffa8394ec09cac47f842e47f843ad13dc25feb2
Cr-Commit-Position: refs/heads/master@{#410976}

Powered by Google App Engine
This is Rietveld 408576698