Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2221743002: [Media Router WebUI] Fix sink list text styling. (Closed)

Created:
4 years, 4 months ago by apacible
Modified:
4 years, 4 months ago
Reviewers:
imcheng
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Fix sink list text styling. Adds some whitespace at the end of the sink list text. Truncate long names and descriptions with ellipsis. Also updated the width as it truncates the text before the x icon. BUG=630112 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/c332be48a80204bd50e1aa1b3bab0d96497f2919 Cr-Commit-Position: refs/heads/master@{#410603}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
apacible
PTAL, thanks! Can get RTL screenshots if needed. Before: https://screenshot.googleplex.com/Gc7ENJP9UyX.png After: https://screenshot.googleplex.com/VicFes394tU.png
4 years, 4 months ago (2016-08-07 03:41:54 UTC) #9
imcheng
lgtm
4 years, 4 months ago (2016-08-08 18:15:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2221743002/1
4 years, 4 months ago (2016-08-09 05:29:32 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 07:11:30 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 07:13:10 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c332be48a80204bd50e1aa1b3bab0d96497f2919
Cr-Commit-Position: refs/heads/master@{#410603}

Powered by Google App Engine
This is Rietveld 408576698