appengine/memlock/memlock.go - Issue 2221713002: Make memlock less verbose.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/memlock/memlock.go

Issue 2221713002: Make memlock less verbose. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master

Patch Set: Fix process test in tumble Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/memlock/memlock.go

diff --git a/appengine/memlock/memlock.go b/appengine/memlock/memlock.go

index 2f8a0bd5244b7b812f483fce6ed10dfc99f9a3c6..a0ab3a46fef48e977de49ed93ac57bbd28c5ccd0 100644

--- a/appengine/memlock/memlock.go

+++ b/appengine/memlock/memlock.go

@@ -71,9 +71,11 @@ func TryWithLock(ctx context.Context, key, clientID string, f func(context.Conte

return ErrEmptyClientID

}

- ctx = logging.SetField(ctx, "key", key)

- ctx = logging.SetField(ctx, "clientID", clientID)

- log := logging.Get(ctx)

+ log := logging.Get(

+ logging.SetFields(ctx, logging.Fields{

+ "key": key,

+ "clientID": clientID,

+ }))

mc := memcache.Get(ctx)

key = memlockKeyPrefix + key

« no previous file with comments | « no previous file | tumble/process_test.go » ('j') | no next file with comments »