src/api.h - Issue 222163002: Introduce MaybeHandle to police exception checking in handlified code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.h

Issue 222163002: Introduce MaybeHandle to police exception checking in handlified code. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: renamed to MaybeHandle and added template Throw Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/api.h

diff --git a/src/api.h b/src/api.h

index 128087c895137c876bd62de869ba022a8d074afa..3ebdca74ed6090bb449753e4e6c6adfd32666726 100644

--- a/src/api.h

+++ b/src/api.h

@@ -318,9 +318,7 @@ template <class T>

v8::internal::Handle<T> v8::internal::Handle<T>::EscapeFrom(

v8::EscapableHandleScope* scope) {

v8::internal::Handle<T> handle;

- if (!is_null()) {

- handle = *this;

- }

+ if (!this->is_null()) handle = *this;

return Utils::OpenHandle(*scope->Escape(Utils::ToLocal(handle)), true);

}

« no previous file with comments | « no previous file | src/handles.h » ('j') | src/handles.h » ('J')