Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 2221613002: [Mac] Fix hacker_case problems in Omnibox source. (Closed)

Created:
4 years, 4 months ago by shrike
Modified:
4 years, 4 months ago
Reviewers:
tapted
CC:
chromium-reviews, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Fix hacker_case problems in Omnibox source. Recent changes to Mac Omnibox code include hacker_case variables and a hacker_case method name (!!). This cl fixes those mistakes. R=tapted@chromium.org BUG=635129 Committed: https://crrev.com/ede179b31679b2e3de86fce9bc623c0dfc9dd98a Cr-Commit-Position: refs/heads/master@{#410704}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.mm View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
shrike
PTAL
4 years, 4 months ago (2016-08-05 22:04:38 UTC) #1
tapted
lgtm
4 years, 4 months ago (2016-08-09 02:53:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2221613002/1
4 years, 4 months ago (2016-08-09 15:58:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 16:45:44 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 16:49:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ede179b31679b2e3de86fce9bc623c0dfc9dd98a
Cr-Commit-Position: refs/heads/master@{#410704}

Powered by Google App Engine
This is Rietveld 408576698