Don't update profile information when the sync state changes.

chrome/browser/ui/webui/options/browser_options_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/browser_options_handler.h"
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 640 matching lines @@
                  base::Unretained(this)));
 #else
   web_ui()->RegisterMessageCallback(
       "restartBrowser",
       base::Bind(&BrowserOptionsHandler::HandleRestartBrowser,
                  base::Unretained(this)));
 #endif
 }
 
 void BrowserOptionsHandler::OnStateChanged() {
+  UpdateSyncState();
+}
+
+void BrowserOptionsHandler::UpdateSyncState() {

[Adrian Kuegel, 2013/08/06 10:05:35]

Can you move this function (and OnSigninAllowedPrefChange) down corresponding to
their position in the header file?
I guess the functions in this file should at least be ordered by public
functions first, then private.

[Bernhard Bauer, 2013/08/06 10:38:49]

Done.

   web_ui()->CallJavascriptFunction("BrowserOptions.updateSyncState",
                                    *GetSyncStateDictionary());
-
-  SendProfilesInfo();

[Adrian Kuegel, 2013/08/06 10:05:35]

I haven't completely understood if removing this line might break something, but
from what I can tell the call should be covered by the
chrome::NOTIFICATION_PROFILE_CACHED_INFO_CHANGED.
Anyway, the documentation of the OnStateChanged method seems to suggest to query
the sync service about what kind of change occurred, so that might also be an
option.

[Bernhard Bauer, 2013/08/06 10:38:49]

Yes, I traced this back to when it was added originally, and the two updates
were just lumped together in the same method (OnStateChanged sounds kind of
general).
Well, ProfileSyncService sends the notification among other things after every
sync cycle, so nothing would even have changed there.

 }
 
 void BrowserOptionsHandler::OnSigninAllowedPrefChange() {
-  web_ui()->CallJavascriptFunction("BrowserOptions.updateSyncState",
-                                   *GetSyncStateDictionary());
-
-  SendProfilesInfo();
+  UpdateSyncState();
 }
 
 void BrowserOptionsHandler::PageLoadStarted() {
   page_initialized_ = false;
 }
 
 void BrowserOptionsHandler::InitializeHandler() {
   Profile* profile = Profile::FromWebUI(web_ui());
   PrefService* prefs = profile->GetPrefs();
 
@@ skipping 1045 matching lines @@
   base::FundamentalValue disabled(proxy_config &&
                                   !proxy_config->IsUserModifiable());
   base::FundamentalValue extension_controlled(is_extension_controlled);
   web_ui()->CallJavascriptFunction("BrowserOptions.setupProxySettingsSection",
                                    disabled, extension_controlled);
 
 #endif  // !defined(OS_CHROMEOS)
 }
 
 }  // namespace options