MD Settings: About page, allow error messages to contain HTML.

MD Settings: About page, allow error messages to contain HTML.

BUG=623926
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/ad0ffd45a843ab8bdfca7e7d38365d7bb8e61e1c
Cr-Commit-Position: refs/heads/master@{#410250}

[dpapad, 2016-08-05 19:30:07]

Description was changed from

==========
MD Settings: About page, allow error messages to contain HTML.

BUG=623926
==========

to

==========
MD Settings: About page, allow error messages to contain HTML.

BUG=623926
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-08-05 19:31:09]

dpapad@chromium.org changed reviewers:
+ tommycli@chromium.org

[dpapad, 2016-08-05 20:18:29]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org
- tommycli@chromium.org

[Dan Beam, 2016-08-05 22:58:33]

can we run this through parseHtmlSubset() easily?

https://codereview.chromium.org/2221563002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/about_page/about_page.html (right):

https://codereview.chromium.org/2221563002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/about_page/about_page.html:93:
currentUpdateStatusEvent_)]]">
indent off

[dpapad, 2016-08-05 23:31:45]

Added a call to parseHtmlSubset.

https://codereview.chromium.org/2221563002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/about_page/about_page.html (right):

https://codereview.chromium.org/2221563002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/about_page/about_page.html:93:
currentUpdateStatusEvent_)]]">
On 2016/08/05 at 22:58:33, Dan Beam wrote:
> indent off

Done.

[Dan Beam, 2016-08-05 23:45:28]

lgtm

https://codereview.chromium.org/2221563002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/about_page/about_page.html (right):

https://codereview.chromium.org/2221563002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/about_page/about_page.html:18: <link
rel="import"
href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
<link rel="import" href="chrome://resources/html/parse_html_subset.html">

https://codereview.chromium.org/2221563002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/about_page/about_page.js (right):

https://codereview.chromium.org/2221563002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/about_page/about_page.js:181:
this.currentUpdateStatusEvent_.message).firstChild.outerHTML :
nit:

var message = this.currentUpdateStatusEvent_.message;
return message ? parseHtmlSubset(message).firstChild.outerHtml : '';

[Dan Beam, 2016-08-05 23:47:50]

https://codereview.chromium.org/2221563002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/about_page/about_page.js (right):

https://codereview.chromium.org/2221563002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/about_page/about_page.js:181:
this.currentUpdateStatusEvent_.message).firstChild.outerHTML :
wait, doesn't this only work if it starts with 1 (and only 1) tag?

[Dan Beam, 2016-08-05 23:49:30]

https://codereview.chromium.org/2221563002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/about_page/about_page.js (right):

https://codereview.chromium.org/2221563002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/about_page/about_page.js:181:
this.currentUpdateStatusEvent_.message).firstChild.outerHTML :
On 2016/08/05 23:47:50, Dan Beam wrote:
> wait, doesn't this only work if it starts with 1 (and only 1) tag?

I think parseHtmlSubset('<b>' + text + '</b>').firstChild.innerHTML might be
more common/reliable?

[dpapad, 2016-08-06 00:00:14]

https://codereview.chromium.org/2221563002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/about_page/about_page.js (right):

https://codereview.chromium.org/2221563002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/about_page/about_page.js:181:
this.currentUpdateStatusEvent_.message).firstChild.outerHTML :
On 2016/08/05 at 23:49:30, Dan Beam wrote:
> On 2016/08/05 23:47:50, Dan Beam wrote:
> > wait, doesn't this only work if it starts with 1 (and only 1) tag?
> 
> I think parseHtmlSubset('<b>' + text + '</b>').firstChild.innerHTML might be
more common/reliable?

Good catch. Done.

[dpapad, 2016-08-06 00:41:59]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-08-06 00:42:00]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2221563002/#ps40001
(title: "Fix.")

[commit-bot: I haz the power, 2016-08-06 00:42:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-06 01:40:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-06 01:42:46]

Description was changed from

==========
MD Settings: About page, allow error messages to contain HTML.

BUG=623926
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: About page, allow error messages to contain HTML.

BUG=623926
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/ad0ffd45a843ab8bdfca7e7d38365d7bb8e61e1c
Cr-Commit-Position: refs/heads/master@{#410250}
==========

[commit-bot: I haz the power, 2016-08-06 01:42:46]

Patchset 3 (id:??) landed as
https://crrev.com/ad0ffd45a843ab8bdfca7e7d38365d7bb8e61e1c
Cr-Commit-Position: refs/heads/master@{#410250}