Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2221563002: MD Settings: About page, allow error messages to contain HTML. (Closed)

Created:
4 years, 4 months ago by dpapad
Modified:
4 years, 4 months ago
Reviewers:
Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: About page, allow error messages to contain HTML. BUG=623926 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/ad0ffd45a843ab8bdfca7e7d38365d7bb8e61e1c Cr-Commit-Position: refs/heads/master@{#410250}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Done. #

Total comments: 5

Patch Set 3 : Fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M chrome/browser/resources/settings/about_page/about_page.html View 1 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/about_page/about_page.js View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/about_page/compiled_resources2.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
dpapad
4 years, 4 months ago (2016-08-05 19:31:09 UTC) #3
Dan Beam
can we run this through parseHtmlSubset() easily? https://codereview.chromium.org/2221563002/diff/1/chrome/browser/resources/settings/about_page/about_page.html File chrome/browser/resources/settings/about_page/about_page.html (right): https://codereview.chromium.org/2221563002/diff/1/chrome/browser/resources/settings/about_page/about_page.html#newcode93 chrome/browser/resources/settings/about_page/about_page.html:93: currentUpdateStatusEvent_)]]"> indent ...
4 years, 4 months ago (2016-08-05 22:58:33 UTC) #5
dpapad
Added a call to parseHtmlSubset. https://codereview.chromium.org/2221563002/diff/1/chrome/browser/resources/settings/about_page/about_page.html File chrome/browser/resources/settings/about_page/about_page.html (right): https://codereview.chromium.org/2221563002/diff/1/chrome/browser/resources/settings/about_page/about_page.html#newcode93 chrome/browser/resources/settings/about_page/about_page.html:93: currentUpdateStatusEvent_)]]"> On 2016/08/05 at ...
4 years, 4 months ago (2016-08-05 23:31:45 UTC) #6
Dan Beam
lgtm https://codereview.chromium.org/2221563002/diff/20001/chrome/browser/resources/settings/about_page/about_page.html File chrome/browser/resources/settings/about_page/about_page.html (right): https://codereview.chromium.org/2221563002/diff/20001/chrome/browser/resources/settings/about_page/about_page.html#newcode18 chrome/browser/resources/settings/about_page/about_page.html:18: <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html"> <link rel="import" href="chrome://resources/html/parse_html_subset.html"> https://codereview.chromium.org/2221563002/diff/20001/chrome/browser/resources/settings/about_page/about_page.js File ...
4 years, 4 months ago (2016-08-05 23:45:28 UTC) #7
Dan Beam
https://codereview.chromium.org/2221563002/diff/20001/chrome/browser/resources/settings/about_page/about_page.js File chrome/browser/resources/settings/about_page/about_page.js (right): https://codereview.chromium.org/2221563002/diff/20001/chrome/browser/resources/settings/about_page/about_page.js#newcode181 chrome/browser/resources/settings/about_page/about_page.js:181: this.currentUpdateStatusEvent_.message).firstChild.outerHTML : wait, doesn't this only work if it ...
4 years, 4 months ago (2016-08-05 23:47:50 UTC) #8
Dan Beam
https://codereview.chromium.org/2221563002/diff/20001/chrome/browser/resources/settings/about_page/about_page.js File chrome/browser/resources/settings/about_page/about_page.js (right): https://codereview.chromium.org/2221563002/diff/20001/chrome/browser/resources/settings/about_page/about_page.js#newcode181 chrome/browser/resources/settings/about_page/about_page.js:181: this.currentUpdateStatusEvent_.message).firstChild.outerHTML : On 2016/08/05 23:47:50, Dan Beam wrote: > ...
4 years, 4 months ago (2016-08-05 23:49:30 UTC) #9
dpapad
https://codereview.chromium.org/2221563002/diff/20001/chrome/browser/resources/settings/about_page/about_page.js File chrome/browser/resources/settings/about_page/about_page.js (right): https://codereview.chromium.org/2221563002/diff/20001/chrome/browser/resources/settings/about_page/about_page.js#newcode181 chrome/browser/resources/settings/about_page/about_page.js:181: this.currentUpdateStatusEvent_.message).firstChild.outerHTML : On 2016/08/05 at 23:49:30, Dan Beam wrote: ...
4 years, 4 months ago (2016-08-06 00:00:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2221563002/40001
4 years, 4 months ago (2016-08-06 00:42:38 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-06 01:40:30 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-06 01:42:46 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ad0ffd45a843ab8bdfca7e7d38365d7bb8e61e1c
Cr-Commit-Position: refs/heads/master@{#410250}

Powered by Google App Engine
This is Rietveld 408576698